Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] fix TestRunMain test #12675

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Conversation

rdhabalia
Copy link
Contributor

Motivation

PulsarAdminTool returns with exist-code 0 with empty argument.
TestRunMain::runMainNoArguments checks incorrect assertion. this change was introduced by #12581

java.lang.AssertionError: expected [1] but found [0]
	at org.testng.Assert.fail(Assert.java:99)
	at org.testng.Assert.failNotEquals(Assert.java:1037)
	at org.testng.Assert.assertEqualsImpl(Assert.java:140)
	at org.testng.Assert.assertEquals(Assert.java:122)
	at org.testng.Assert.assertEquals(Assert.java:907)
	at org.testng.Assert.assertEquals(Assert.java:917)
	at org.apache.pulsar.admin.cli.TestRunMain.runMainNoArguments(TestRunMain.java:35)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)

Modification

  • fix the test
  • add reset method to handle static code to avoid test failure due to previous tests.

@rdhabalia rdhabalia added this to the 2.10.0 milestone Nov 8, 2021
@rdhabalia rdhabalia self-assigned this Nov 8, 2021
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

@rdhabalia:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

@rdhabalia:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@Anonymitaet
Copy link
Member

Hi @rdhabalia do we need to update docs for this PR?

@codelipenghui codelipenghui mentioned this pull request Nov 9, 2021
1 task
@rdhabalia rdhabalia merged commit 24b0f4f into apache:master Nov 9, 2021
@rdhabalia rdhabalia deleted the runmain_test branch November 9, 2021 07:42
@Anonymitaet Anonymitaet added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 11, 2021
codelipenghui pushed a commit that referenced this pull request Nov 18, 2021
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Nov 18, 2021
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker area/test cherry-picked/branch-2.8 Archived: 2.8 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants