Pulsar Client: restore SchemaInfo.builder() API #12673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codelipenghui @merlimat I would commit this to branch-2.9 before cutting the new RC |
merlimat
approved these changes
Nov 8, 2021
codelipenghui
approved these changes
Nov 9, 2021
|
the failed test has been fixed here #12675 |
|
/pulsarbot run-failure-checks |
|
@nicoloboschi I have rebased onto latest master |
eolivelli
force-pushed
the
fix/SchemaInfoBuilder
branch
from
8ef4d36
to
137b684
Compare
eolivelli
added a commit
that referenced
this pull request
Nov 9, 2021
(cherry picked from commit 849e4dc)
eolivelli
added a commit
that referenced
this pull request
Nov 10, 2021
(cherry picked from commit 849e4dc)
|
I have cherry picked this to branch-2.8 |
eolivelli
added a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12670
Motivation
In 2.8.0 we dropped SchemaInfo.builder() API and so it is no more possible to create a SchemaInfo instance without using SchemaInfoImpl internal class.
Modifications
Restore a Builder, I used Delombok in order to get the same results as before.
Unfortunately SchemaInfo is now an interface, it was a class in 2.7, so we cannot really fix the breaking change at runtime, but at least users will be able to simply rebuild their code.
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
no-need-doc