[Broker] Make PersistentTopicsBase#internalSetBacklogQuota async #14051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation See apache#13854 Modification * Make PersistentTopicsBase#internalSetBacklogQuota async. * Change getRetentionPolicies to getRetentionPoliciesAsync Signed-off-by: Zike Yang <zkyang@streamnative.io>
Signed-off-by: Zike Yang <zkyang@streamnative.io>
nodece
reviewed
Feb 7, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Zike Yang <zkyang@streamnative.io>
nodece
approved these changes
Feb 7, 2022
codelipenghui
approved these changes
Feb 8, 2022
codelipenghui
requested review from
Jason918,
Technoboy-,
315157973 and
hangc0276
315157973
approved these changes
Feb 8, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #13854
Motivation
See #13854
Modifications
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
no-need-doc