[fix][metrics]wrong metrics text generated when label_cluster specified #17704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@poorbarcode Please provide a correct documentation label for your PR. |
poorbarcode
force-pushed
the
fix/metrics_generate
branch
from
188b1a4
to
e9ad9c9
Compare
|
This PR should merge into the following branches:
|
github-actions
bot
added
doc-not-needed
gaoran10
reviewed
Sep 19, 2022
| @@ -67,14 +68,21 @@ public static void generateSystemMetrics(SimpleTextOutputStream stream, String c | |||
| stream.write(sample.name); | |||
| if (!sample.labelNames.contains("cluster")) { | |||
There was a problem hiding this comment.
Maybe we can add this stream.write("{"); before the check if (!sample.labelNames.contains("cluster")). The symbol { is necessary and it's easier to understand.
There was a problem hiding this comment.
That's a good idea. The code has been changed
poorbarcode
force-pushed
the
fix/metrics_generate
branch
from
2980fdb
to
3023772
Compare
gaoran10
reviewed
Sep 19, 2022
| import java.util.Collections; | ||
| import java.util.UUID; | ||
| import org.testng.annotations.Test; | ||
|
|
There was a problem hiding this comment.
Please add the test group.
There was a problem hiding this comment.
Already add test group
poorbarcode
force-pushed
the
fix/metrics_generate
branch
from
3023772
to
bd65de8
Compare
|
/pulsarbot rerun-failure-checks |
nodece
approved these changes
Sep 21, 2022
Technoboy-
approved these changes
Sep 22, 2022
|
/pulsarbot rerun-failure-checks |
shoothzj
approved these changes
Sep 22, 2022
|
Hi @Technoboy- Can this PR merge? (^_^) |
Merged
14 tasks
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 10, 2023
…ster specified (apache#17704) (apache#18919) Co-authored-by: fengyubiao <yubiao.feng@streamnative.io> (cherry picked from commit a530ab2)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 11, 2023
…ster specified (apache#17704) (apache#18919) Co-authored-by: fengyubiao <yubiao.feng@streamnative.io> (cherry picked from commit a530ab2)
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
…ed (#17704) * [fix][metrics]wrong metrics text generated when label_cluster specified * improve logic branch * mark test group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If
label_clusterspecifiedcluster_123, the expected metrics text is:but the actual metrics text is :
High light: lost a char
{Modifications
Make metrics text generate correct
Documentation
doc-requireddoc-not-neededdocdoc-completeMatching PR in forked repository
PR in forked repository: