[improve][test] Bump TestNG to 7.6.1 #18521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot rerun-failure-checks |
nodece
changed the title
tisonkun
reviewed
Nov 17, 2022
Comment on lines
+111
to
+115
| <dependency> | ||
| <groupId>org.hamcrest</groupId> | ||
| <artifactId>hamcrest</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Interesting. Why do we need this dependency explicitly now?
There was a problem hiding this comment.
I don't know why ~, maybe the old testNG includes this library?
pom.xml
Outdated
| @@ -241,7 +241,7 @@ flexible messaging model and an intuitive client API.</description> | |||
| <!-- Set docker-java.version to the version of docker-java used in Testcontainers --> | |||
| <docker-java.version>3.2.13</docker-java.version> | |||
| <kerby.version>1.1.1</kerby.version> | |||
| <testng.version>7.3.0</testng.version> | |||
| <testng.version>7.5</testng.version> | |||
There was a problem hiding this comment.
I learn the latest version is 7.6.1. Why do we use 7.5 here? Also, 7.5 is not of a full semantic version format.
There was a problem hiding this comment.
7.6.1 requires JDK 11 or higher. The Pulsar-CI have a JDK 8 test.
tisonkun
approved these changes
Nov 18, 2022
|
Try to bump TestNG to 7.6.1. |
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
force-pushed
the
bump-testng-7.5.0
branch
from
eb813f3
to
86c60bb
Compare
nodece
changed the title
tisonkun
approved these changes
Nov 18, 2022
Codecov Report
@@ Coverage Diff @@
## master #18521 +/- ##
============================================
- Coverage 45.62% 45.28% -0.34%
- Complexity 10075 10693 +618
============================================
Files 697 757 +60
Lines 68024 72781 +4757
Branches 7293 7817 +524
============================================
+ Hits 31033 32961 +1928
- Misses 33413 36154 +2741
- Partials 3578 3666 +88
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
All tests passed. Merging... |
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Dec 9, 2022
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bump TestNG to 7.6.1
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: nodece#14