[cleanup] Consolidate certs used in tests #20336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
added
doc
|
/pulsarbot rerun-failure-checks |
michaeljmarshall
force-pushed
the
consolidate-certs-tests
branch
from
1bab09a
to
05342e9
Compare
Codecov Report
@@ Coverage Diff @@
## master #20336 +/- ##
============================================
+ Coverage 72.93% 72.95% +0.01%
+ Complexity 31973 31972 -1
============================================
Files 1868 1868
Lines 138663 138663
Branches 15248 15248
============================================
+ Hits 101133 101156 +23
+ Misses 29484 29457 -27
- Partials 8046 8050 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
approved these changes
May 17, 2023
This was referenced May 18, 2023
lhotari
pushed a commit
that referenced
this pull request
Jan 26, 2024
Builds on: #20289 There are many certificates in our test code base. It would be much simpler to have one place were we create and manage certificates so that when we need to make changes, they are consolidated. There is likely one or two more PRs to finish consolidating certs. * Remove certs that are no longer used * Replace references to old certs with references to the `certificate-authority` certs * Create new server certs with valid hostnames on them so that tests will pass. Document the process used to create these certs. * Fix an issue in the `PulsarTestContext` where the configuration was not correctly updated. * Remove configurations that allow for insecure connections in tests that are doing some kind of TLS verification. The only places where we leave insecure validation in place is tests that are specifically verifying the functionality. * Copy `certificate-authority` to the relevant `bouncy-castle` directory When tests pass, this change will be correctly verified. - [x] `doc` This PR includes doc changes PR in forked repository: michaeljmarshall#48 (cherry picked from commit d45a220)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on: #20289
Motivation
There are many certificates in our test code base. It would be much simpler to have one place were we create and manage certificates so that when we need to make changes, they are consolidated.
There is likely one or two more PRs to finish consolidating certs.
Modifications
certificate-authoritycertsPulsarTestContextwhere the configuration was not correctly updated.certificate-authorityto the relevantbouncy-castledirectoryVerifying this change
When tests pass, this change will be correctly verified.
Documentation
docThis PR includes doc changes
Matching PR in forked repository
PR in forked repository: michaeljmarshall#48