Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][sec] Support for Elliptic Curve Cryptography (EC, ECC) (certificates/private keys) #21621

Merged
merged 12 commits into from
Nov 27, 2023
Merged

[improve][sec] Support for Elliptic Curve Cryptography (EC, ECC) (certificates/private keys) #21621

merged 12 commits into from
Nov 27, 2023

Conversation

mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Nov 24, 2023

Fixes #21599 #11431

Motivation

Support for Elliptic Curve Cryptography (EC, ECC) (certificates/private keys)

Modifications

  • Support for Elliptic Curve Cryptography (EC, ECC) (certificates/private keys)

Verifying this change

  • Make sure that the change passes the CI checks.

  • I already added the JKS and certificate file test.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@mattisonchao mattisonchao self-assigned this Nov 24, 2023
@mattisonchao mattisonchao modified the milestones: 3.0, 3.2.0 Nov 24, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 24, 2023
@mattisonchao mattisonchao reopened this Nov 24, 2023
@mattisonchao mattisonchao reopened this Nov 24, 2023
@mattisonchao mattisonchao changed the title [improve][security] Support for Elliptic Curve Cryptography (EC, ECC) (certificates/private keys) [improve][sec] Support for Elliptic Curve Cryptography (EC, ECC) (certificates/private keys) Nov 24, 2023
@mattisonchao mattisonchao marked this pull request as draft November 24, 2023 15:47
@mattisonchao mattisonchao marked this pull request as ready for review November 25, 2023 07:28
@mattisonchao mattisonchao added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Nov 25, 2023
@mattisonchao mattisonchao reopened this Nov 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2023

Codecov Report

Merging #21621 (2d2b7f9) into master (5229a73) will increase coverage by 39.91%.
The diff coverage is 62.50%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21621       +/-   ##
=============================================
+ Coverage     33.38%   73.29%   +39.91%     
- Complexity    12246    32616    +20370     
=============================================
  Files          1640     1892      +252     
  Lines        128195   140698    +12503     
  Branches      14008    15494     +1486     
=============================================
+ Hits          42795   103127    +60332     
+ Misses        79742    29469    -50273     
- Partials       5658     8102     +2444     
Flag Coverage Δ
inttests 24.12% <43.75%> (+0.01%) ⬆️
systests 24.70% <0.00%> (?)
unittests 72.63% <62.50%> (+40.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...org/apache/pulsar/common/util/SecurityUtility.java 79.91% <62.50%> (+20.09%) ⬆️

... and 1543 files with indirect coverage changes

Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good! I left my own opinion.

@mattisonchao mattisonchao merged commit e1d06b5 into apache:master Nov 27, 2023
46 of 48 checks passed
@mattisonchao mattisonchao deleted the improve/support_ec_certificate branch November 27, 2023 12:08
mattisonchao added a commit to streamnative/pulsar-archived that referenced this pull request Dec 7, 2023
mattisonchao added a commit to streamnative/pulsar-archived that referenced this pull request Dec 7, 2023
mattisonchao added a commit to streamnative/pulsar-archived that referenced this pull request Dec 28, 2023
mattisonchao added a commit to streamnative/pulsar-archived that referenced this pull request Dec 28, 2023
mattisonchao added a commit to streamnative/pulsar-archived that referenced this pull request Dec 28, 2023
coderzc pushed a commit to coderzc/pulsar that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security doc-not-needed Your PR changes do not impact docs ready-to-test type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ECDSA X509 private keys are crashing the brokers
6 participants