-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][sec] Support for Elliptic Curve Cryptography (EC, ECC) (certificates/private keys) #21621
Merged
mattisonchao
merged 12 commits into
apache:master
from
mattisonchao:improve/support_ec_certificate
Nov 27, 2023
Merged
[improve][sec] Support for Elliptic Curve Cryptography (EC, ECC) (certificates/private keys) #21621
mattisonchao
merged 12 commits into
apache:master
from
mattisonchao:improve/support_ec_certificate
Nov 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #21621 +/- ##
=============================================
+ Coverage 33.38% 73.29% +39.91%
- Complexity 12246 32616 +20370
=============================================
Files 1640 1892 +252
Lines 128195 140698 +12503
Branches 14008 15494 +1486
=============================================
+ Hits 42795 103127 +60332
+ Misses 79742 29469 -50273
- Partials 5658 8102 +2444
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Nov 27, 2023
poorbarcode
approved these changes
Nov 27, 2023
RobertIndie
approved these changes
Nov 27, 2023
nodece
reviewed
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good! I left my own opinion.
pulsar-common/src/main/java/org/apache/pulsar/common/util/SecurityUtility.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/base/MockedPulsarStandalone.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/base/MockedPulsarStandalone.java
Outdated
Show resolved
Hide resolved
…rityUtility.java Co-authored-by: Zixuan Liu <nodeces@gmail.com>
mattisonchao
added a commit
to streamnative/pulsar-archived
that referenced
this pull request
Dec 7, 2023
…tificates/private keys) (apache#21621) (cherry picked from commit e1d06b5)
15 tasks
mattisonchao
added a commit
to streamnative/pulsar-archived
that referenced
this pull request
Dec 7, 2023
…tificates/private keys) (apache#21621) (cherry picked from commit e1d06b5)
mattisonchao
added a commit
to streamnative/pulsar-archived
that referenced
this pull request
Dec 28, 2023
…tificates/private keys) (apache#21621) (cherry picked from commit e1d06b5)
mattisonchao
added a commit
to streamnative/pulsar-archived
that referenced
this pull request
Dec 28, 2023
…tificates/private keys) (apache#21621) (cherry picked from commit e1d06b5)
mattisonchao
added a commit
to streamnative/pulsar-archived
that referenced
this pull request
Dec 28, 2023
…tificates/private keys) (apache#21621) (cherry picked from commit e1d06b5)
coderzc
pushed a commit
to coderzc/pulsar
that referenced
this pull request
Aug 14, 2024
…tificates/private keys) (apache#21621) (cherry picked from commit e1d06b5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/security
doc-not-needed
Your PR changes do not impact docs
ready-to-test
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21599 #11431
Motivation
Support for Elliptic Curve Cryptography (EC, ECC) (certificates/private keys)
Modifications
Verifying this change
Make sure that the change passes the CI checks.
I already added the JKS and certificate file test.
Documentation
doc
doc-required
doc-not-needed
doc-complete