[fix][broker] Fix lookupRequestSemaphore leak when topic not found #21646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pengxiangrui127 Please add the following content to your PR description and select a checkbox: |
github-actions
bot
added
doc-not-needed
Technoboy-
reviewed
Nov 30, 2023
| @@ -79,6 +79,7 @@ protected CompletableFuture<LookupData> internalLookupTopicAsync(final TopicName | |||
| }) | |||
| .thenCompose(exist -> { | |||
| if (!exist) { | |||
| pulsar().getBrokerService().getLookupRequestSemaphore().release(); | |||
There was a problem hiding this comment.
A better way to fix this is moving exceptionally(line-135) to line-139. WDYT?
There was a problem hiding this comment.
A better way to fix this is moving
exceptionally(line-135) to line-139. WDYT?
thx to review. It is a good idea, i will recommit it.
pengxiangrui127
force-pushed
the
fix_lookup_semaphore_leak
branch
from
cecb76b
to
9ed2d9f
Compare
Technoboy-
approved these changes
Dec 2, 2023
poorbarcode
reviewed
Dec 2, 2023
joeCarf
approved these changes
Dec 3, 2023
poorbarcode
approved these changes
Dec 4, 2023
2 tasks
Technoboy-
pushed a commit
that referenced
this pull request
Dec 4, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Dec 4, 2023
|
No need to cherry-pick to branch-2.10, because 2.10 doesn't has this issue. |
4 tasks
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function internalLookupTopicAsync is invoked by http protocol topic lookup request. The lookupRequestSemaphore would leaked when lookuping topic is not exist.
Motivation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: