[fix][test] add unit test to testing the lookupRequestSemaphore would leaked when lookuping topic is not exist. #21670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #21661
PIP: #21646
Motivation
Function internalLookupTopicAsync is invoked by http protocol topic lookup request. The lookupRequestSemaphore would leaked when lookuping topic is not exist.
Now use a unit test to see if it is actually released
Modifications
Add a unit test to simulate this process, and the state should be the same
Documentation
docdoc-requireddoc-not-neededdoc-complete