Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][io] Upgrade Debezium oracle connector version to 2.5.4.Final #22813

Closed
wants to merge 2 commits into from

Conversation

mukesh154
Copy link
Contributor

@mukesh154 mukesh154 commented May 31, 2024

Fixes #22626

Motivation

To Upgrade debezium version for oracle to 2.5.4.Final

Modifications

Upgraded debezium version from 1.9.7.Final to 2.5.4.Final just for oracle connector, so that other connectors such as mysql, postgresql, mongodb, mssql doesn't break.

Verifying this change

  • Make sure that the change passes the CI checks.

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

Check the box below or label this PR directly (if you have committer privilege).

Need to update docs?

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Copy link

@mukesh154 Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels May 31, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 212 lines in your changes missing coverage. Please review.

Project coverage is 73.17%. Comparing base (bbc6224) to head (2ecf604).
Report is 355 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22813      +/-   ##
============================================
- Coverage     73.57%   73.17%   -0.41%     
- Complexity    32624    32960     +336     
============================================
  Files          1877     1892      +15     
  Lines        139502   141902    +2400     
  Branches      15299    15569     +270     
============================================
+ Hits         102638   103830    +1192     
- Misses        28908    30054    +1146     
- Partials       7956     8018      +62     
Flag Coverage Δ
inttests 27.41% <ø> (+2.82%) ⬆️
systests 24.73% <0.00%> (+0.40%) ⬆️
unittests 72.31% <ø> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ulsar/io/debezium/oracle/DebeziumOracleSource.java 0.00% <ø> (ø)
...g/apache/pulsar/io/debezium/oracle/SerDeUtils.java 0.00% <0.00%> (ø)
...ache/pulsar/io/debezium/oracle/DebeziumSource.java 0.00% <0.00%> (ø)
...lsar/io/debezium/oracle/PulsarDatabaseHistory.java 0.00% <0.00%> (ø)

... and 384 files with indirect coverage changes

Comment on lines +48 to +52
<dependency>
<groupId>io.debezium</groupId>
<artifactId>debezium-core</artifactId>
<version>${debezium.oracle.version}</version>
</dependency>
Copy link
Member

@lhotari lhotari Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a great idea to have a separate version of debezium-core when Oracle connector is used. This will cause class version conflicts as we have seen before. Please see #22668 as an example of this.

I think that should be upgrading Debezium in all connectors at the same time to avoid class version conflicts and the confusion caused for maintenance when multiple versions of Debezium are used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Infinispan Client Hotrod has a vulnerability CVE-2023-4586
5 participants