Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue#4155][pulsar-clients]Support key value schema versioning #4211

Merged
merged 5 commits into from
May 20, 2019
Merged

[issue#4155][pulsar-clients]Support key value schema versioning #4211

merged 5 commits into from
May 20, 2019

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented May 6, 2019

Fixes #4155

Master Issue: #4155

Motivation

Similar to AVRO and JSON schema, we need to support schema versioning for key/value schema.

Modifications

Support key value schema versioning.

Verifying this change

unit test pass

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

sijie
sijie requested changes May 7, 2019
View reviewed changes
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/KeyValueSchema.java Outdated Show resolved Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/KeyValueSchema.java Outdated Show resolved Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/KeyValueSchema.java Outdated Show resolved Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/KeyValueSchema.java Outdated Show resolved Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/KeyValueSchema.java Outdated Show resolved Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/KeyValueSchema.java Outdated Show resolved Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/KeyValueSchema.java Outdated Show resolved Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java Outdated Show resolved Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java Outdated Show resolved Hide resolved
@tuteng
Format Code
2474b28 
Add return default value
@tuteng
Copy link
Member Author

tuteng commented May 8, 2019

run java8 tests

1 similar comment
@tuteng
Copy link
Member Author

tuteng commented May 10, 2019

run java8 tests

@tuteng
Copy link
Member Author

tuteng commented May 16, 2019

run java8 tests

3 similar comments
@tuteng
Copy link
Member Author

tuteng commented May 17, 2019

run java8 tests

@tuteng
Copy link
Member Author

tuteng commented May 17, 2019

run java8 tests

@tuteng
Copy link
Member Author

tuteng commented May 17, 2019

run java8 tests

@sijie
Copy link
Member

sijie commented May 18, 2019

run java8 tests

@sijie sijie added this to the 2.4.0 milestone May 18, 2019
@sijie sijie added the type/feature The PR added a new feature or issue requested a new feature label May 18, 2019
codelipenghui
codelipenghui approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm +1

@sijie sijie merged commit 58986a8 into apache:master May 20, 2019
@sijie
Copy link
Member

sijie commented May 20, 2019

Great contribution! @tuteng

@Huanli-Meng Huanli-Meng mentioned this pull request Jul 1, 2020
Merged
jiazhai pushed a commit that referenced this pull request Jul 1, 2020
@Huanli-Meng
schema version (#7417)
3c422f0 
Motivation
Pulsar 2.4.0 Added schema versioning to support multi version messages produce and consume #3876 #3670 #4211 #4325 #4548. but the doc is not updated accordingly.

Modifications
Update the schema version in the pulsar registry doc for releases 2.4.0/2.4.1/2.4.2.
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@Huanli-Meng @huangdx0726
schema version (apache#7417)
b774c47 
Motivation
Pulsar 2.4.0 Added schema versioning to support multi version messages produce and consume apache#3876 apache#3670 apache#4211 apache#4325 apache#4548. but the doc is not updated accordingly.

Modifications
Update the schema version in the pulsar registry doc for releases 2.4.0/2.4.1/2.4.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

Assignees

@tuteng tuteng

Labels
type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Support schema versioning in key/value schema
3 participants
@tuteng @sijie @codelipenghui