[schema] key/value schema enhancement #4548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Motivation* - The code for encoding and decoding key/value schema is spreading over multiple places. - Make code changes to prepare supporting key/value schema in AUTO consumers - Make schema tools display key/value schema in a pretty format *Modifications* - Move the common logic of encoding and decoding key/value schema to a common class KeyValueSchemaInfo - Expose the common class in DefaultImplementation so that it can be available for public usage - Fix the display problem on displaying key/value schema *Verify this change* - Add bunch of the unit tests for key/value schemas
sijie
added
type/enhancement
|
retest this please |
codelipenghui
approved these changes
Jun 18, 2019
| @@ -36,7 +37,7 @@ | |||
| /** | |||
| * Message schema definition | |||
| */ | |||
| public interface Schema<T> { | |||
| public interface Schema<T> extends SchemaWriter<T> { | |||
There was a problem hiding this comment.
Why consider to inherit SchemaWriter?
sijie
commented
Jun 18, 2019
| * @param valueWriter a writer to encode value object | ||
| * @return the encoded bytes array | ||
| */ | ||
| public static <K, V> byte[] encode(K key, SchemaWriter<K> keyWriter, |
There was a problem hiding this comment.
@codelipenghui since I only need a serialize method for serializing K or V into bytes. so I use SchemaWriter as the interface in the util functions. To use existing Schema interface, I extend Schema interface to SchemaWriter. Maybe I can just rewrite it using a different approach to get rid of extending Schema from SchemaWriter. Let me give it a shot.
|
@codelipenghui I have addressed your comment. PTAL |
|
run java8 tests |
|
@sijie 👍, LGTM. |
|
run java8 tests |
|
run java8 tests |
1 similar comment
|
run java8 tests |
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Motivation Pulsar 2.4.0 Added schema versioning to support multi version messages produce and consume apache#3876 apache#3670 apache#4211 apache#4325 apache#4548. but the doc is not updated accordingly. Modifications Update the schema version in the pulsar registry doc for releases 2.4.0/2.4.1/2.4.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Verify this change