[schema] AutoConsume should use the schema associated with messages as both writer and reader schema #4325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or both writer and reader schema *Motivation* AutoConsume should use the schema associated with the messages for decoding the schemas. *Modifications* - provide a flag enable or disable using the provided schema as the reader schema - for AUTO_CONSUME schema, disable usnig the provided schema as the reader schema. so it can use the right schema version for decoding messages into right generic records - provide a few util methods for displaying schema data
|
/cc @tuteng @congbobo184 |
1 task
congbobo184
reviewed
May 21, 2019
| @@ -732,11 +732,14 @@ protected void preProcessSchemaBeforeSubscribe(PulsarClientImpl pulsarClientImpl | |||
| SchemaInfo schemaInfo = schemaInfoProvider.getLatestSchema(); | |||
| if (schemaInfo.getType() != SchemaType.AVRO){ | |||
There was a problem hiding this comment.
I think here can add SchemaType.JSON
congbobo184
approved these changes
May 22, 2019
|
run Java8 Tests |
|
run java8 tests |
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Motivation Pulsar 2.4.0 Added schema versioning to support multi version messages produce and consume apache#3876 apache#3670 apache#4211 apache#4325 apache#4548. but the doc is not updated accordingly. Modifications Update the schema version in the pulsar registry doc for releases 2.4.0/2.4.1/2.4.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
AutoConsume should use the schema associated with the messages for decoding the schemas.
Modifications
schema version for decoding messages into right generic records