Allow for topic deletions with regex consumers #5230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/enhancement
|
run cpp tests |
|
run integration tests |
|
run java8 tests |
|
@jiazhai since you are familiar with regex subscription and also involved in the original discussion, can you please take a look at this change? |
aahmed-se
approved these changes
Sep 24, 2019
|
run java8 tests |
1 similar comment
|
run java8 tests |
|
The pr change the proto file, will move the milestone to |
This was referenced Jan 19, 2020
|
I've just created #6136 to fix the release notes |
sijie
pushed a commit
that referenced
this pull request
Jan 25, 2020
### Motivation *A change that had to be moved to 2.5.0 (because it [changed the .proto file](#5230 (comment))), is still listed as having been done in 2.4.2 in the release notes.* ### Modifications *Move the change from 2.4.2 to 2.5.0.*
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
### Motivation *A change that had to be moved to 2.5.0 (because it [changed the .proto file](apache#5230 (comment))), is still listed as having been done in 2.4.2 in the release notes.* ### Modifications *Move the change from 2.4.2 to 2.5.0.*
7 tasks
7 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently it's not possible to delete topics when there is a regex consumer attached to them. The reason is that the regex consumer will immediately reconnect and cause the topic to be re-created.
Modifications