-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted #22854
[fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted #22854
Conversation
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
Outdated
Show resolved
Hide resolved
pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternMultiTopicsConsumerImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
Outdated
Show resolved
Hide resolved
/pulsarbot rerun-failure-checks |
c4f3f7e
to
6a5e3f0
Compare
Rebased master |
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternConsumerUpdateQueue.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternMultiTopicsConsumerImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternMultiTopicsConsumerImpl.java
Show resolved
Hide resolved
Closing and reopening to trigger CI with latest master branch changes. |
2dbbeb1
to
24b59e8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22854 +/- ##
============================================
- Coverage 73.57% 73.44% -0.13%
- Complexity 32624 33337 +713
============================================
Files 1877 1913 +36
Lines 139502 143383 +3881
Branches 15299 15637 +338
============================================
+ Hits 102638 105308 +2670
- Misses 28908 30038 +1130
- Partials 7956 8037 +81
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/LookupServiceTest.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
Show resolved
Hide resolved
…ns of a topic have been deleted (apache#22854) (cherry picked from commit 9626e7e) (cherry picked from commit 98d4a53)
…ns of a topic have been deleted (apache#22854) (cherry picked from commit 9626e7e) (cherry picked from commit 98d4a53)
Motivation
Background
1.Regarding the API getting topics by regexp pattern, there are two implementations:*
List<String> HttpLookupService.getPartitionedTopicMetadata(...)
CommandGetTopicsOfNamespace BinaryProtoLookupService.getPartitionedTopicMetadata(...)
Pulsar transferred both response types
List<String>
andCommandGetTopicsOfNamespace
to aGetTopicsResult
object. And discarded the partition information when doing transference. For example:topic-1-partition-0
,topic-1-partition-1
.topic-1
.2.The behavior of Patten consumers
createTopicIfDoesNotExist
of Multi Topics Consumer tofalse
.Issue
Modifications
createTopicIfDoesNotExist
isfalse
.Addational things
flink-connector-pulsar also has the same issue
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x