Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add topic-level APIs for deduplication snapshot interval, inactive topic policies and offload policies #14396

Merged
merged 5 commits into from
Mar 1, 2022
Merged

[Doc] Add topic-level APIs for deduplication snapshot interval, inactive topic policies and offload policies #14396

merged 5 commits into from
Mar 1, 2022

Conversation

momo-jun
Copy link
Contributor

@momo-jun momo-jun commented Feb 21, 2022 •
edited
Loading

Modifications

Add the following contents to align doc with code PRs.

  1. For Support taking de-duplication snapshots based on time #8474: add a parameter brokerDeduplicationSnapshotIntervalSeconds to the broker configurations and cookbook.
  2. For Support topic-level DeduplicationSnapshotInterval #8552: add a section of APIs to configure topic-level de-duplication snapshot interval.
  3. For Support topic-level inactiveTopicPolicies #7986: add a section of APIs to configure topic-level inactive topic policies.
  4. For Support topicl level offload #7883: add a section of APIs to configure topic-level offload.

Preview

image

image

image

Documentation

  • doc

@github-actions
Copy link

@momo-jun:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions
Copy link

@momo-jun:Thanks for providing doc info!

@github-actions github-actions bot added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-label-missing labels Feb 21, 2022
@momo-jun
Copy link
Contributor Author

Hi @315157973 @codelipenghui @Anonymitaet, can you please review this doc PR? Thanks.

Please kindly note that the same changes will be applied to more historical versions since 2.7.0 as soon as it gets approval.

@momo-jun momo-jun changed the title [Doc] DeduplicationSnapshotInterval: add broker-level config and topic-level APIs [Doc] [Do-not-Merge] DeduplicationSnapshotInterval: add broker-level config and topic-level APIs Feb 21, 2022
Anonymitaet
Anonymitaet previously approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from the technical writing pespective

site2/docs/admin-api-topics.md Outdated Show resolved Hide resolved
@momo-jun momo-jun changed the title [Doc] [Do-not-Merge] DeduplicationSnapshotInterval: add broker-level config and topic-level APIs [Doc] [Do-not-Merge] Add topic-level APIs for deduplication snapshot interval, inactive topic policies and offload policies Feb 21, 2022
315157973
315157973 reviewed Feb 28, 2022
View reviewed changes
site2/docs/admin-api-topics.md
<!--Pulsar-admin API-->

```
pulsar-admin topics remove-offload-policies options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like "remove" doesn't need any options, just pass in the topic name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your comment. However, the Pulsar admin API doc shows the "options" in the remove command. Which one shall we keep using consistently?
https://pulsar.apache.org/tools/pulsar-admin/2.10.0-SNAPSHOT/#-em-remove-offload-policies-em--89

@momo-jun momo-jun changed the title [Doc] [Do-not-Merge] Add topic-level APIs for deduplication snapshot interval, inactive topic policies and offload policies [Doc] Add topic-level APIs for deduplication snapshot interval, inactive topic policies and offload policies Feb 28, 2022
@Anonymitaet Anonymitaet merged commit 3c08686 into apache:master Mar 1, 2022
@Anonymitaet Anonymitaet added this to the 2.10.0 milestone Mar 1, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
@momo-jun
[Doc] Add topic-level APIs for deduplication snapshot interval, inact…
6356eb6 
…ive topic policies and offload policies (apache#14396)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@315157973 315157973 315157973 approved these changes

@Anonymitaet Anonymitaet Anonymitaet left review comments

Assignees

@momo-jun momo-jun

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@momo-jun @315157973 @Anonymitaet