-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RATIS-1071. NettyClientRpc supports sendRequestAsync. #1122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @szetszwo for picking this up. I have a question related to one of the tests, other than that, it looks good.
import org.junit.jupiter.api.Assertions; | ||
import org.junit.jupiter.api.Test; | ||
|
||
public class TestNettyClientRpcAsync extends BaseTest implements MiniRaftClusterWithNetty.FactoryGet { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to keep this test? According to #204 (comment) it can be removed, since we are also adding TestRaftAsyncWithNetty extends RaftAsyncTests
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. We don't need this test anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 the patch looks good to me.
Thanks @adoroszlai and @SzyWilliam for reviewing this! |
…Rui Wang and Tsz-Wo Nicholas Sze. (#1122)
See RATIS-1071.
This is continuing the work in #204
When merging this pull request, please include "
Contributed by Rui Wang and Tsz-Wo Nicholas Sze
".