RATIS-1071. NettyClientRpc supports sendRequestAsync #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@szetszwo any feedback on this change? |
|
@szetszwo fridenly ping~ |
szetszwo
requested changes
Sep 28, 2020
| @@ -67,7 +67,11 @@ | |||
| <scope>test</scope> | |||
| <type>test-jar</type> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
| <groupId>junit</groupId> | |||
There was a problem hiding this comment.
Please move the test to ratis-test.
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
|
|
||
| public class TestNettyClientRpcAsync extends BaseTest implements MiniRaftClusterWithNetty.FactoryGet { |
There was a problem hiding this comment.
Please add a test extending RaftAsyncTests; see TestRaftAsyncWithGrpc. Then, this test can be removed.
|
@amaliujia , thanks a lot for your initial work! I will continue this pull request in #1122 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Expose
sendRequestAsyncAPI inNettyClientRpc.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1071
How was this patch tested?
UT