-
Notifications
You must be signed in to change notification settings - Fork 97
[REEF-743] Convert project files to Visual Studio 2015 #873
Conversation
I rebased and force-pushed this. |
I try to open O.A.R.VS2013.sln with VS 2013, and build fails:
(followed by a bunch of "Metadata file could not be found", which I think are caused by failures to build earlier dlls) The machine also has VS 2015 installed, if that is important. |
Same machine, when I try to run
with build tools for v120 (the same VS 2013 setup I'm using for builds now), it fails
|
Looking into it. |
@tcNickolas I removed the
Can you give that a shot? Next step would be to somehow make VS 2013 call |
These parameters seem to work for command-line set up for VS 2013, and this change works with normal build command for VS 2015 (both from command-line and VS itself). |
Yay! I am working on automating this now. |
@tcNickolas I removed one command line parameter, and it works for me via:
Can you confirm? |
I've replaced the commit in here with a new one that makes the solution compile on both VS 2013 and VS 2015 for me. We need to test this in a couple of environments:
|
I just tried on a machine with only VS 2015. Builds worked on both the command line and within VS. |
Build works for me both for VS 2015 and 2013, both from VS and from command-line. |
Excellent! All we need now is confirmation that this works for machines with only Visual Studio 2013 installed. @shulmanb, can you test that? |
Will do that on Monday. -----Original Message----- Excellent! All we need now is confirmation that this works for machines with only Visual Studio 2013 installed. @shulmanb, can you test that? |
I tried it with the machine which has only VS 2013 installed, both build and test are passed. Must install maven 3.3.x though. That is required by the latest change for build script, not related to VS 2015. |
Oh, I thought our build instructions at https://cwiki.apache.org/confluence/display/REEF/Compiling+REEF require 3.3, but they're actually "3 or newer". 3.2 and older don't support some of the switches I used. We should update build instructions with REEF-1254 |
Thanks, @jwang98052! Can we go ahead and merge this, then? |
Actually, hold off for a bit. I'd like to update the README.md with the new information |
This adds conditionals to `Org.Apache.REEF.Bridge.vcxproj` to switch the `PlatformToolset` based on the version of Visual Studio. This allows the same .sln to be compiled on Visual Studio 2013 and 2015. This also updates README.md with the build instructions for VS 2015. JIRA: [REEF-743](https://issues.apache.org/jira/browse/REEF-743) Pull Request: This closes #
Rebased and squashed. |
@markusweimer Builds fine for me |
No concerns raised, so I'll do one last test and merge. |
I'll also add restriction about Maven 3.3 or newer, while we're at editing our README. |
This converts
Org.Apache.REEF.Bridge.vcxproj
to Visual Studio 2015 format.This also adds a new solution
Org.Apache.REEF.VS2013.sln
as well as a newOrg.Apache.REEF.Bridge.VS2013.vcxproj
for users of that version of VisualStudio.
JIRA:
REEF-743