-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #103]Support resolvePlaceholders for selectorExpression #129
Conversation
@RocketMQMessageListener(topic = "${demo.rocketmq.test.consumer.topic}",selectorExpression="${demo.rocketmq.test.consumer.tags}" ,consumerGroup = "${demo.rocketmq.test.consumer.group}")
Ref ISSUE #103 |
I tried your modify, but it do not work. Because when |
@liuliuzo Maybe you should delete the code |
@RongtongJin sorry i will build environment and adding test before submit next time. i am not delete this.selectorExpression = anno.selectorExpression(); in setRocketMQMessageListener method. because selectorExpression should have default value '*', other idea is change container.setRocketMQMessageListener(annotation); order in createRocketMQListenerContainer |
@liuliuzo It would be helpful to verify if you could add some test in your polish. I would like to follow up and help to merge this pr:-) |
@vongosling sorry,i will better improve my pull request quality next time. |
update master
@@ -272,5 +293,24 @@ public RocketMQTemplate extRocketMQTemplate() { | |||
static class MyExtRocketMQTemplate extends RocketMQTemplate { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you modify the class MyExtRocketMQTemplate name, you could assign a concrete name Instead of a name with no actual meaning my**?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done : )
…estyle and update test class with actual meaning.
…estyle and update test class with actual meaning.
@RocketMQMessageListener(topic =
"${demo.rocketmq.test.consumer.topic}",selectorExpression="${demo.rocketmq.test.consumer.tags}"
,consumerGroup = "${demo.rocketmq.test.consumer.group}")
What is the purpose of the change
purpose to support resolvePlaceholders for selectorExpression
Brief changelog
modify ListenerContainerConfiguration.java
modify DefaultRocketMQListenerContainer.java