Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How RocketMQMessageListener Sets Tag? #103

Closed
syanfox opened this issue Jul 11, 2019 · 6 comments
Closed

How RocketMQMessageListener Sets Tag? #103

syanfox opened this issue Jul 11, 2019 · 6 comments

Comments

@syanfox
Copy link

syanfox commented Jul 11, 2019

No description provided.

@fangjian0423
Copy link
Member

Refer RocketMQMessageListener#selectorExpression.

this attribute can be used for tag or sql subscribe mode, the subscribe mode refer RocketMQMessageListener#selectorType.

@xue2lang
Copy link

@fangjian0423 now the tag not support resolvePlaceholders （eg：selectorExpression=${my.xx.tag} ），the default is * 。 when used，we should implement RocketMQPushConsumerLifecycleListener to set other info。
RocketMQMessageListener define the property （selectorExpression），but it doesn't seem to be working friendly now

@fangjian0423
Copy link
Member

fangjian0423 commented Jul 16, 2019 •
edited

contributors are welcome to support resolvePlaceholders.

@xue2lang
Copy link

@fangjian0423 i review the source code ；ListenerContainerConfiguration#createRocketMQListenerContainer set instance of RocketMQMessageListener to instance of DefaultRocketMQListenerContainer，then execute the method DefaultRocketMQListenerContainer#initRocketMQPushConsumer 。I cannot find resolvePlaceholders where be used for the property of selectorExpression

@fangjian0423
Copy link
Member

@fangjian0423 i review the source code ；ListenerContainerConfiguration#createRocketMQListenerContainer set instance of RocketMQMessageListener to instance of DefaultRocketMQListenerContainer，then execute the method DefaultRocketMQListenerContainer#initRocketMQPushConsumer 。I cannot find resolvePlaceholders where be used for the property of selectorExpression

It is not supported and welcome to contribute it.

liuliuzo pushed a commit to liuliuzo/rocketmq-spring that referenced this issue Aug 22, 2019
fix:apache#103 support resolvePlaceholders for selectorExpression
4e719a9 
@RocketMQMessageListener(topic =
"${demo.rocketmq.test.consumer.topic}",selectorExpression="${demo.rocketmq.test.consumer.tags}"
,consumerGroup = "${demo.rocketmq.test.consumer.group}")
liuliuzo pushed a commit to liuliuzo/rocketmq-spring that referenced this issue Aug 22, 2019
fix:apache#103 support resolvePlaceholders for selectorExpression cod…
a380c88 
…estyle

check
@liuliuzo
Copy link
Contributor

@fangjian0423 我的这个pull request 有机会被merge吗？

@ShannonDing ShannonDing mentioned this issue Aug 30, 2019
Merged
@syanfox syanfox closed this as completed Sep 3, 2019
@Shellbye Shellbye mentioned this issue Sep 24, 2019
Closed
5 tasks
liuliuzo pushed a commit to liuliuzo/rocketmq-spring that referenced this issue Sep 27, 2019
fix:apache#103 support resolvePlaceholders for selectorExpression cod…
95ca292 
…estyle
liuliuzo pushed a commit to liuliuzo/rocketmq-spring that referenced this issue Sep 27, 2019
fix:apache#103 support resolvePlaceholders for selectorExpression cod…
f85574d 
…estyle
liuliuzo pushed a commit to liuliuzo/rocketmq-spring that referenced this issue Sep 28, 2019
fix:apache#103 support resolvePlaceholders for selectorExpression cod…
d8a38d3 
…estyle
liuliuzo pushed a commit to liuliuzo/rocketmq-spring that referenced this issue Oct 28, 2019
fix:apache#103 support resolvePlaceholders for selectorExpression cod…
be8b8a4 
…estyle

and update test class with actual meaning.
liuliuzo pushed a commit to liuliuzo/rocketmq-spring that referenced this issue Oct 28, 2019
fix:apache#103 support resolvePlaceholders for selectorExpression cod…
24ac48d 
…estyle

and update test class with actual meaning.
duhenglucky added a commit that referenced this issue Oct 31, 2019
@duhenglucky
Merge pull request #129 from liuliuzo/master
71a1e9c 
[ISSUE #103]Support resolvePlaceholders for selectorExpression
liuliuzo pushed a commit to liuliuzo/rocketmq-spring that referenced this issue Mar 26, 2020
fix:apache#103 support resolvePlaceholders for selectorExpression
e8b1321 
@RocketMQMessageListener(topic =
"${demo.rocketmq.test.consumer.topic}",selectorExpression="${demo.rocketmq.test.consumer.tags}"
,consumerGroup = "${demo.rocketmq.test.consumer.group}")
liuliuzo pushed a commit to liuliuzo/rocketmq-spring that referenced this issue Mar 26, 2020
fix:apache#103 support resolvePlaceholders for selectorExpression cod…
0af61f0 
…estyle

check
liuliuzo pushed a commit to liuliuzo/rocketmq-spring that referenced this issue Mar 26, 2020
fix:apache#103 support resolvePlaceholders for selectorExpression cod…
73c1a9f 
…estyle
liuliuzo pushed a commit to liuliuzo/rocketmq-spring that referenced this issue Mar 26, 2020
fix:apache#103 support resolvePlaceholders for selectorExpression cod…
b568106 
…estyle
liuliuzo pushed a commit to liuliuzo/rocketmq-spring that referenced this issue Mar 26, 2020
fix:apache#103 support resolvePlaceholders for selectorExpression cod…
5d5581f 
…estyle
liuliuzo added a commit to liuliuzo/rocketmq-spring that referenced this issue Mar 26, 2020
@liuliuzo
fix:apache#103 support resolvePlaceholders for selectorExpression cod…
d88b221 
…estyle

and update test class with actual meaning.
liuliuzo added a commit to liuliuzo/rocketmq-spring that referenced this issue Mar 26, 2020
@liuliuzo
fix:apache#103 support resolvePlaceholders for selectorExpression cod…
249e492 
…estyle

and update test class with actual meaning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@liuliuzo @fangjian0423 @syanfox @xue2lang