Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #103]SelectorType.TAG support placeholder #148

Closed
wants to merge 1 commit into from

Conversation

Shellbye
Copy link

@Shellbye Shellbye commented Sep 22, 2019

What is the purpose of the change

@RocketMQMessageListener support SelectorType.TAG placeholder

@Service
@RocketMQMessageListener(
        topic = "${mq.topic}",
        consumerGroup = "ConsumerGroup1",
        messageModel = MessageModel.BROADCASTING,
        selectorType = SelectorType.TAG,
        selectorExpression = "${mq.tag}"
)
public class Consumer implements RocketMQListener<String> {
    @Override
    public void onMessage(String message) {
        System.out.printf("\n\n\n------- Consumer received: %s \n\n\n\n", message);
    }
}

Brief changelog

org.apache.rocketmq.spring.support.DefaultRocketMQListenerContainer
private void initRocketMQPushConsumer()

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@RongtongJin
Copy link
Contributor

There is a similar PR in the list.

@Shellbye
Copy link
Author

There is a similar PR in the list.

The similar PR does not consider SelectorType.SQL92.

@Shellbye Shellbye changed the title SelectorType.TAG support placeholder [ISSUE #103] SelectorType.TAG support placeholder Sep 24, 2019
@Shellbye
Copy link
Author

#103

@vongosling vongosling changed the title [ISSUE #103] SelectorType.TAG support placeholder [ISSUE #103]SelectorType.TAG support placeholder Oct 28, 2019
@vongosling
Copy link
Member

@Shellbye considering there was a similar problem earlier, could you help to clarify your pr purpose?

@RongtongJin
Copy link
Contributor

I will temporarily close this PR, and please feel free to reopen it if you want to do more work with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants