Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static initializer in MessageClientIDSetter #1751

Closed
rushsky518 opened this issue Jan 29, 2020 · 1 comment
Closed

static initializer in MessageClientIDSetter #1751

rushsky518 opened this issue Jan 29, 2020 · 1 comment
Labels
type/bug
Milestone
4.7.0

Comments

@rushsky518
Copy link
Contributor

rushsky518 commented Jan 29, 2020 •
edited

org.apache.rocketmq.common.message.MessageClientIDSetter

image

pid may be erased
rushsky518 added a commit to rushsky518/rocketmq that referenced this issue Feb 3, 2020
@rushsky518
apache#1751 fix bug and add a unit test
4fb7710
@rushsky518 rushsky518 mentioned this issue Feb 12, 2020
Merged
rushsky518 added a commit to rushsky518/rocketmq that referenced this issue Feb 12, 2020
@rushsky518
apache#1751 short pid
81a1956
@duhenglucky duhenglucky added this to the 4.6.2 milestone Feb 12, 2020
rushsky518 added a commit to rushsky518/rocketmq that referenced this issue Feb 12, 2020
@rushsky518
apache#1751 remove repeat code
5de8764
duhenglucky pushed a commit that referenced this issue Feb 12, 2020
@rushsky518
[ISSUE #1751]Fix bug in MessageClientIDSetter (#1758)
689e770 
* pid 4bytes

* pid is 4 bytes

* #1751 fix bug and add a unit test

* #1751 short pid

* 保持原来

* #1751 remove repeat code
@duhenglucky
Copy link
Contributor

fixed

@duhenglucky duhenglucky modified the milestones: 4.6.2, 4.7.0 Feb 28, 2020
gnehcgnaw pushed a commit to gnehcgnaw/rocketmq that referenced this issue Apr 4, 2020
Merge branch 'master' of https://github.com/apache/rocketmq
adc19e8 
* 'master' of https://github.com/apache/rocketmq: (248 commits)
  [maven-release-plugin] prepare release rocketmq-all-4.7.0
  fix(test):fix the issue that MessageClientIDSetter#getIPFromID return wrong pid when pid greater than short type max value
  chore(all):update the year in notice file and correct header in NamespaceUtilTest
  chore(version):modify current version to prepare release 4.7.0
  fix(pull_schedual) add the namespace wrapper in callback (apache#1804)
  chore(pom):update fastjson version (apache#1795)
  [ISSUE apache#1787] Fix the issue that queryCq command of mqadmin returned incorrect data (apache#1793)
  Improve exception handle of transaction check service (apache#1783)
  Fix asynchronous send retry
  min value for autoCommitIntervalMillis.   apache#1774 (apache#1775)
  [ISSUE apache#1771]add MessageExt.getBrokerName   for issue  (apache#1772)
  [ISSUE apache#1751]Fix bug in MessageClientIDSetter (apache#1758)
  [ISSUE apache#1409] Fix the bug when use queryMsgByKey or queryMsgByUniqueKey command in aclEnable = true (apache#1756)
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release rocketmq-all-4.6.1
  feat(release):update version to release 4.6.1
  correct spelling
  optimise benchmark consumer, add consume fail rate option
  typo fix (apache#1723)
  [ISSUE apache#1656] Fix StatsItem bug (apache#1704)
  ...
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this issue May 28, 2020
@rushsky518
[ISSUE apache#1751]Fix bug in MessageClientIDSetter (apache#1758)
ae1dd1a 
* pid 4bytes

* pid is 4 bytes

* apache#1751 fix bug and add a unit test

* apache#1751 short pid

* 保持原来

* apache#1751 remove repeat code
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this issue Aug 12, 2022
@rushsky518
[ISSUE apache#1751]Fix bug in MessageClientIDSetter (apache#1758)
20443f5 
* pid 4bytes

* pid is 4 bytes

* apache#1751 fix bug and add a unit test

* apache#1751 short pid

* 保持原来

* apache#1751 remove repeat code
pulllock pushed a commit to pulllock/rocketmq that referenced this issue Oct 19, 2023
@rushsky518
[ISSUE apache#1751]Fix bug in MessageClientIDSetter (apache#1758)
6f48059 
* pid 4bytes

* pid is 4 bytes

* apache#1751 fix bug and add a unit test

* apache#1751 short pid

* 保持原来

* apache#1751 remove repeat code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
4.7.0
Development

No branches or pull requests
2 participants
@duhenglucky @rushsky518