Skip to content

Conversation

@uglycow
Copy link
Contributor

@uglycow uglycow commented Jan 14, 2020

What is the purpose of the change

fix typo
Fix Issue

Brief changelog

fix typo

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 50.882% when pulling b279cd6 on uglycow:develop into 678cab3 on apache:develop.

@duhenglucky duhenglucky added this to the 4.6.1 milestone Jan 15, 2020
@duhenglucky duhenglucky changed the title typo fix [ISSUE # 1724]typo fix Jan 15, 2020
@duhenglucky duhenglucky merged commit 881f767 into apache:develop Jan 15, 2020
RongtongJin pushed a commit that referenced this pull request Jan 20, 2020
gnehcgnaw pushed a commit to gnehcgnaw/rocketmq that referenced this pull request Apr 4, 2020
* 'master' of https://github.com/apache/rocketmq: (248 commits)
  [maven-release-plugin] prepare release rocketmq-all-4.7.0
  fix(test):fix the issue that MessageClientIDSetter#getIPFromID return wrong pid when pid greater than short type max value
  chore(all):update the year in notice file and correct header in NamespaceUtilTest
  chore(version):modify current version to prepare release 4.7.0
  fix(pull_schedual) add the namespace wrapper in callback (apache#1804)
  chore(pom):update fastjson version (apache#1795)
  [ISSUE apache#1787] Fix the issue that queryCq command of mqadmin returned incorrect data (apache#1793)
  Improve exception handle of transaction check service (apache#1783)
  Fix asynchronous send retry
  min value for autoCommitIntervalMillis.   apache#1774 (apache#1775)
  [ISSUE apache#1771]add MessageExt.getBrokerName   for issue  (apache#1772)
  [ISSUE apache#1751]Fix bug in MessageClientIDSetter (apache#1758)
  [ISSUE apache#1409] Fix the bug when use queryMsgByKey or queryMsgByUniqueKey command in aclEnable = true (apache#1756)
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release rocketmq-all-4.6.1
  feat(release):update version to release 4.6.1
  correct spelling
  optimise benchmark consumer, add consume fail rate option
  typo fix (apache#1723)
  [ISSUE apache#1656] Fix StatsItem bug (apache#1704)
  ...
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Dec 10, 2020
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
pulllock pushed a commit to pulllock/rocketmq that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants