[ISSUE #1774]min value for autoCommitIntervalMillis. #1774 #1775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 14, 2020 16:31
duhenglucky
reviewed
Feb 14, 2020
|
|
||
| public void setAutoCommitIntervalMillis(long autoCommitIntervalMillis) { | ||
| this.autoCommitIntervalMillis = autoCommitIntervalMillis; | ||
| if (autoCommitIntervalMillis >= 1000) { |
Contributor
There was a problem hiding this comment.
It would be better if you can replace this magic number(1000) with a constant variable.
duhenglucky
approved these changes
Feb 14, 2020
duhenglucky
changed the title
gnehcgnaw
pushed a commit
to gnehcgnaw/rocketmq
that referenced
this pull request
Apr 4, 2020
* 'master' of https://github.com/apache/rocketmq: (248 commits) [maven-release-plugin] prepare release rocketmq-all-4.7.0 fix(test):fix the issue that MessageClientIDSetter#getIPFromID return wrong pid when pid greater than short type max value chore(all):update the year in notice file and correct header in NamespaceUtilTest chore(version):modify current version to prepare release 4.7.0 fix(pull_schedual) add the namespace wrapper in callback (apache#1804) chore(pom):update fastjson version (apache#1795) [ISSUE apache#1787] Fix the issue that queryCq command of mqadmin returned incorrect data (apache#1793) Improve exception handle of transaction check service (apache#1783) Fix asynchronous send retry min value for autoCommitIntervalMillis. apache#1774 (apache#1775) [ISSUE apache#1771]add MessageExt.getBrokerName for issue (apache#1772) [ISSUE apache#1751]Fix bug in MessageClientIDSetter (apache#1758) [ISSUE apache#1409] Fix the bug when use queryMsgByKey or queryMsgByUniqueKey command in aclEnable = true (apache#1756) [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release rocketmq-all-4.6.1 feat(release):update version to release 4.6.1 correct spelling optimise benchmark consumer, add consume fail rate option typo fix (apache#1723) [ISSUE apache#1656] Fix StatsItem bug (apache#1704) ...
JiaMingLiu93
pushed a commit
to JiaMingLiu93/rocketmq
that referenced
this pull request
May 28, 2020
* typo fix * add MessageExt.getBrokerName() * add brokerName for toString * get brokerName from mq * min value for autoCommitInterval * use constant variable
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
* typo fix * add MessageExt.getBrokerName() * add brokerName for toString * get brokerName from mq * min value for autoCommitInterval * use constant variable
pulllock
pushed a commit
to pulllock/rocketmq
that referenced
this pull request
Oct 19, 2023
* typo fix * add MessageExt.getBrokerName() * add brokerName for toString * get brokerName from mq * min value for autoCommitInterval * use constant variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
prevent the client from committing too frequently, we set 1000ms as min value for autoCommitIntervalMillis
fix issue
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.