[ROCKETMQ-14]invoke callback shoule be invoked in an executor rather than in current thread. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jaskey Thanks for your PR, Could you paste some unit test for these question :-) . please see our contributing checklist, https://github.com/apache/incubator-rocketmq/blob/master/CONTRIBUTING.md |
Jaskey
changed the title
… executor rather than in timer thread.
|
please check the commited unit test . |
Jaskey
changed the title
|
Source code seems ok, please @zhouxinyu @lollipopjin review it |
|
Hi, This PR has been merged, but next time please use JIRA issue name( Thanks. |
Closed
lyx2000
added a commit
to lyx2000/rocketmq
that referenced
this pull request
Jun 30, 2023
# This is the 1st commit message: add acl event Signed-off-by: lyx <1419360299@qq.com> # This is the commit message apache#2: add update acl config event Signed-off-by: lyx <1419360299@qq.com> # This is the commit message apache#3: refactor(event): fix rename Signed-off-by: lyx <1419360299@qq.com> # This is the commit message apache#4: refactor(acl): track acl update event Signed-off-by: lyx <1419360299@qq.com> # Conflicts: # acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For success callback, processResponseCommand will execute invoke callback in a saparate executor rather than the time thread.
But for timeout problem , the timeout callback will be invoked directly in timer thread/netty selector thread.
If the user put some time-cost task when timeout, the other timeout callback will be blocked to schedule.
JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-14