[ROCKETMQ-6] Use logger for exceptions instead of e.printStackTrace(). #3

shroman · 2016-12-22T08:30:00Z

See https://issues.apache.org/jira/browse/ROCKETMQ-6

vongosling · 2016-12-23T03:05:20Z

@shroman Thanks your PR

Could you abide our PR process(modify your PR subject and mention your jira address in the description), please follow this PR. #5

shroman · 2016-12-23T04:34:01Z

@vongosling sure, but where can I find the description of the process?

Btw, modifying the subject, etc. can be done when you merge.

shroman · 2016-12-23T05:07:18Z

@vongosling I modified as you requested ;) Please have a look.

JIRA Issue: https://issues.apache.org/jira/browse/ROCKETMQ-6 Merge branch 'master' into ROCKETMQ-6

lollipopjin · 2016-12-29T07:02:27Z

@shroman Could you please squash your commits and fix conflicts.

shroman · 2016-12-29T08:58:28Z

@lollipopjin I resolved the conflicts, now you can review.
How about squashing all commits when you merge after reviewing this issue? My concern is -- I merged this to the master, so if I squash, it will be very hard for you to review.

zhouxinyu · 2017-01-10T02:43:36Z

Hi, @shroman

About e.printStackTrace(), the error message should log to file surely, but can we keep the e.printStackTrace() if the call stack is in broker start process. IMO, print the error message to stderr will be more visualized, the developers can quick locate the reason why broker start failed.

And I have another question, why this PR prefer to use + to concat string instead of using format string?

shroman · 2017-01-10T02:52:05Z

Hi @zhouxinyu

I am not sure if I understand your 1st point though, but if you are saying about printing to stdout or stderr so that users can find problems with brokers from the command line, for instance, quickly,
I think this can be configured via logger xml configuration, right?

As for the 2nd point, I used + just because I am not sure what is the preferred way for the project -- both + and {} through the project. Shall we make a rule for this in http://rocketmq.apache.org/docs/code-guidelines/?

lizhanhui · 2017-01-10T02:59:08Z

@shroman Please use parameterized template formatting way. See http://slf4j.org/faq.html section "What is the fastest way of (not) logging?"

JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-6 Changed logging to use parameterized template formatting.

shroman · 2017-01-10T03:53:08Z

@lizhanhui Ok. I changed my modifications to parameterized template formatting.

@zhouxinyu If you feel this issue needs more careful logging consideration, I don't mind if you assign this JIRA issue to yourself ;) You are working with the project on the daily basis and can tune it better.
Anyway, I think it's better to move stdout logging to slf4j etc. as much as possible.

vongosling · 2017-01-11T03:20:26Z

IMO, we should prefer slf4j or String.format effective format way to log in 4.x :-)

shroman · 2017-01-11T04:03:20Z

@vongosling I completely agree with you

wu-sheng

Only one suggestion.

wu-sheng · 2017-01-11T11:42:37Z

broker/src/main/java/org/apache/rocketmq/broker/processor/PullMessageProcessor.java

@@ -87,8 +87,8 @@ private RemotingCommand processRequest(final Channel channel, RemotingCommand re

        response.setOpaque(request.getOpaque());

-        if (LOG.isDebugEnabled()) {
-            LOG.debug("receive PullMessage request command, {}", request);
+        if (log.isDebugEnabled()) {


log.isDebugEnabled() is not necessary, and do not consistent with other codes log-style.

How is it related to this PR? Please see the title.
That is from the original code, probably you can find ten more small improvements in files I edited but lines I haven't even touched ;)

No related, just think you can change

For this particular place, this can be removed, I agree. But it is good to concenrate the attention on what PR is about.

Agree. Next time, I can bring a new pull request after yours merged.

wu-sheng

👏🏻👏🏻💪

dongeforever · 2017-05-25T08:53:38Z

@shroman please resolve the conflicts and merge this PR

vongosling · 2016-12-27T07:55:18Z

rocketmq-common/src/main/java/com/alibaba/rocketmq/common/MixAll.java

-                    if (log != null) {
-                        log.info(name + "=" + value);
+                    if (logger != null) {
+                        logger.info(name + "=" + value);


please replace {} with + :-)

vongosling · 2016-12-27T07:56:06Z

rocketmq-remoting/src/main/java/com/alibaba/rocketmq/remoting/common/ServiceThread.java

@@ -69,10 +69,10 @@ public void shutdown(final boolean interrupt) {
            long beginTime = System.currentTimeMillis();
            this.thread.join(this.getJointime());
            long eclipseTime = System.currentTimeMillis() - beginTime;
-            STLOG.info("join thread " + this.getServiceName() + " eclipse time(ms) " + eclipseTime + " "
+            log.info("join thread " + this.getServiceName() + " eclipse time(ms) " + eclipseTime + " "


the same question :-)

vongosling · 2016-12-27T07:56:29Z

rocketmq-remoting/src/main/java/com/alibaba/rocketmq/remoting/common/ServiceThread.java

@@ -86,7 +86,7 @@ public void stop() {

    public void stop(final boolean interrupt) {
        this.stopped = true;
-        STLOG.info("stop thread " + this.getServiceName() + " interrupt " + interrupt);
+        log.info("stop thread " + this.getServiceName() + " interrupt " + interrupt);


vongosling · 2016-12-27T07:56:35Z

rocketmq-remoting/src/main/java/com/alibaba/rocketmq/remoting/common/ServiceThread.java

@@ -101,7 +101,7 @@ public void stop(final boolean interrupt) {

    public void makeStop() {
        this.stopped = true;
-        STLOG.info("makestop thread " + this.getServiceName());
+        log.info("makestop thread " + this.getServiceName());


vongosling · 2017-07-04T09:38:29Z

any update? or close it :-)

shroman · 2017-07-04T10:39:10Z

Ok, if it's good to merge, I will resolve the conflicts and merge.

shroman · 2017-07-05T11:39:56Z

Merged to develop branch.

coveralls · 2017-07-05T11:48:49Z

Coverage decreased (-12.4%) to 26.315% when pulling 0baccb7 on shroman:ROCKETMQ-6 into 9ad9ad0 on apache:develop.

coveralls · 2017-07-05T11:48:49Z

Coverage decreased (-12.4%) to 26.315% when pulling 0baccb7 on shroman:ROCKETMQ-6 into 9ad9ad0 on apache:develop.

Develop

merge from apache

# This is the 1st commit message: add acl event Signed-off-by: lyx <1419360299@qq.com> # This is the commit message apache#2: add update acl config event Signed-off-by: lyx <1419360299@qq.com> # This is the commit message apache#3: refactor(event): fix rename Signed-off-by: lyx <1419360299@qq.com> # This is the commit message apache#4: refactor(acl): track acl update event Signed-off-by: lyx <1419360299@qq.com> # Conflicts: # acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java

Develop

shroman added 3 commits December 22, 2016 17:27

Logging instead of printStack(). Fix for ROCKETMQ-6.

7d986da

catch clause without logs

b13daaa

Unified Logger name.

8ec82dc

shroman force-pushed the ROCKETMQ-6 branch from 8ec82dc to b101507 Compare December 23, 2016 04:56

shroman changed the title ~~Logging instead of printStack(). Fix for ROCKETMQ-6.~~ [ROCKETMQ-6] Use logger for exceptions instead of e.printStackTrace(). Dec 23, 2016

shroman force-pushed the ROCKETMQ-6 branch from b101507 to cba6a0f Compare December 23, 2016 05:06

shroman force-pushed the ROCKETMQ-6 branch 2 times, most recently from 4114084 to 297d903 Compare December 28, 2016 10:53

[ROCKETMQ-6] Use logger for exceptions instead of e.printStackTrace()

21d0945

JIRA Issue: https://issues.apache.org/jira/browse/ROCKETMQ-6 Merge branch 'master' into ROCKETMQ-6

shroman force-pushed the ROCKETMQ-6 branch from 297d903 to 21d0945 Compare December 28, 2016 10:54

Merge branch 'master' into ROCKETMQ-6

5984391

[ROCKETMQ-6] Use logger for exceptions instead of e.printStackTrace().

d4a9d16

JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-6 Changed logging to use parameterized template formatting.

wu-sheng reviewed Jan 11, 2017

View reviewed changes

Removed 'isDebugEnabled' where there is no impact on performance.

f6af319

wu-sheng reviewed Jan 11, 2017

View reviewed changes

zhouxinyu mentioned this pull request Jan 20, 2017

[ROCKETMQ-42] Output is not friendly, when Main failed. #35

Closed

vongosling reviewed Jul 4, 2017

View reviewed changes

shroman changed the base branch from master to develop July 5, 2017 10:56

Merged.

0baccb7

shroman closed this Jul 5, 2017

wlliqipeng pushed a commit that referenced this pull request Mar 11, 2019

Merge pull request #3 from apache/develop

8fa4711

Develop

zhibo6 mentioned this pull request Jul 12, 2019

Fix RocketMQ Document Typesetting Errors #1320

Merged

6 tasks

JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020

Merge pull request apache#3 from apache/develop

97a7b9a

Develop

duhenglucky pushed a commit that referenced this pull request Jul 11, 2022

Merge pull request #3 from apache/develop

8a98152

merge from apache

pulllock pushed a commit to pulllock/rocketmq that referenced this pull request Oct 19, 2023

Merge pull request apache#3 from apache/develop

9127278

Develop

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ROCKETMQ-6] Use logger for exceptions instead of e.printStackTrace(). #3

[ROCKETMQ-6] Use logger for exceptions instead of e.printStackTrace(). #3

shroman commented Dec 22, 2016

vongosling commented Dec 23, 2016

shroman commented Dec 23, 2016 •

edited

Loading

shroman commented Dec 23, 2016

lollipopjin commented Dec 29, 2016

shroman commented Dec 29, 2016

zhouxinyu commented Jan 10, 2017

shroman commented Jan 10, 2017

lizhanhui commented Jan 10, 2017

shroman commented Jan 10, 2017

vongosling commented Jan 11, 2017

shroman commented Jan 11, 2017

wu-sheng left a comment

wu-sheng Jan 11, 2017

shroman Jan 11, 2017

wu-sheng Jan 11, 2017

shroman Jan 11, 2017

wu-sheng Jan 11, 2017

wu-sheng left a comment

dongeforever commented May 25, 2017

vongosling Dec 27, 2016

vongosling Dec 27, 2016

vongosling Dec 27, 2016

vongosling Dec 27, 2016

vongosling commented Jul 4, 2017

shroman commented Jul 4, 2017

shroman commented Jul 5, 2017

coveralls commented Jul 5, 2017 •

edited

Loading

coveralls commented Jul 5, 2017

[ROCKETMQ-6] Use logger for exceptions instead of e.printStackTrace(). #3

[ROCKETMQ-6] Use logger for exceptions instead of e.printStackTrace(). #3

Conversation

shroman commented Dec 22, 2016

vongosling commented Dec 23, 2016

shroman commented Dec 23, 2016 • edited Loading

shroman commented Dec 23, 2016

lollipopjin commented Dec 29, 2016

shroman commented Dec 29, 2016

zhouxinyu commented Jan 10, 2017

shroman commented Jan 10, 2017

lizhanhui commented Jan 10, 2017

shroman commented Jan 10, 2017

vongosling commented Jan 11, 2017

shroman commented Jan 11, 2017

wu-sheng left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wu-sheng left a comment

Choose a reason for hiding this comment

dongeforever commented May 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vongosling commented Jul 4, 2017

shroman commented Jul 4, 2017

shroman commented Jul 5, 2017

coveralls commented Jul 5, 2017 • edited Loading

coveralls commented Jul 5, 2017

shroman commented Dec 23, 2016 •

edited

Loading

coveralls commented Jul 5, 2017 •

edited

Loading