Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCKETMQ-8] Standardize build script. #5

Closed
wants to merge 3 commits into from
Closed

[ROCKETMQ-8] Standardize build script. #5

wants to merge 3 commits into from

Conversation

lollipopjin
Copy link
Contributor

@lollipopjin lollipopjin commented Dec 23, 2016 •
edited
Loading

Step1:
Remove original scripts.

JIRA Issue: https://issues.apache.org/jira/browse/ROCKETMQ-8

@vongosling
Copy link
Member

Sorry, we don't merge this PR.
IMO, there is step 2 you must finish :-)

This was referenced Dec 23, 2016
Closed
Closed
Closed
@lollipopjin lollipopjin changed the title [ROCKETMQ-8]Standardize build script using maven wrapper. [ROCKETMQ-8] Standardize build script. Dec 23, 2016
@lollipopjin
Copy link
Contributor Author

lollipopjin commented Dec 23, 2016 •
edited
Loading

@vongosling
I have finished all steps.
All methods to build RocketMQ seems ok in my local env.

@vongosling
Copy link
Member

Thanks for your PR.
I have checked it. It's seems ok for me. please @stevenschew @zhouxinyu review it.

@zhouxinyu
Copy link
Member

It seems ok.

@stevenschew
Copy link
Contributor

review Ok!

@asfgit asfgit closed this in dd985d0 Dec 23, 2016
@zhouxinyu zhouxinyu mentioned this pull request Dec 23, 2016
Closed
@vongosling vongosling mentioned this pull request Jan 13, 2017
Closed
@Jaskey Jaskey mentioned this pull request Feb 24, 2017
Closed
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Jun 25, 2019
@vintagewang
Fix apache#5 测试代码关联性
611fe5e
lizhanhui pushed a commit to lizhanhui/rocketmq that referenced this pull request Jun 25, 2019
@vintagewang
修改例子 (Fix apache#5)
652e446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lollipopjin @vongosling @zhouxinyu @stevenschew