Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RIP-19] Server-side rebalance, lightweight consumer client support #2867

Merged
merged 23 commits into from
Jun 29, 2021

Conversation

duhenglucky
Copy link
Contributor

@duhenglucky duhenglucky commented May 12, 2021

[RIP 19] Server side rebalance, lightweight consumer client support

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@duhenglucky duhenglucky changed the title [RIP-19] Server-side rebalance, Pop consumption model [RIP-19] Server-side rebalance, lightweight consumer client support May 12, 2021
@coveralls
Copy link

coveralls commented May 12, 2021

Coverage Status

Coverage decreased (-1.2%) to 52.583% when pulling 48fa70b on pop_consumer into df1d93f on 5.0.0-preview.

# Conflicts:
#	client/src/test/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumerTest.java
#	client/src/test/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumerTest.java
#	client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQConsumerWithTraceTest.java
#	pom.xml
@vongosling
Copy link
Member

resolve conflict, and we could review after merge it, release it in 4.9.0 after 4.8.1

@vongosling vongosling added the progress/wip Work in progress. Accept or refused to be continue. label May 19, 2021
@duhenglucky duhenglucky changed the base branch from develop to 5.0.0-preview June 16, 2021 06:46
@duhenglucky duhenglucky changed the base branch from 5.0.0-preview to develop June 16, 2021 06:46
@duhenglucky duhenglucky changed the base branch from develop to 5.0.0-preview June 16, 2021 06:49
@zongtanghu zongtanghu modified the milestones: 4.9.0, 5.0.0, 5.0.0-preview Jun 23, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2867 (48fa70b) into 5.0.0-preview (df1d93f) will decrease coverage by 1.48%.
The diff coverage is 30.18%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             5.0.0-preview    #2867      +/-   ##
===================================================
- Coverage            47.97%   46.49%   -1.49%     
- Complexity            4570     4789     +219     
===================================================
  Files                  552      591      +39     
  Lines                36628    40253    +3625     
  Branches              4844     5454     +610     
===================================================
+ Hits                 17573    18716    +1143     
- Misses               16832    19071    +2239     
- Partials              2223     2466     +243     
Impacted Files Coverage Δ
...balance/AllocateMessageQueueAveragelyByCircle.java 0.00% <0.00%> (ø)
...nt/impl/consumer/ConsumeMessageOrderlyService.java 38.84% <0.00%> (-0.15%) ⬇️
...impl/consumer/ConsumeMessagePopOrderlyService.java 0.00% <0.00%> (ø)
...rocketmq/client/impl/consumer/PopProcessQueue.java 0.00% <0.00%> (ø)
...ache/rocketmq/client/impl/consumer/PopRequest.java 0.00% <0.00%> (ø)
.../rocketmq/client/impl/consumer/PullAPIWrapper.java 42.14% <0.00%> (-8.29%) ⬇️
...cketmq/client/impl/consumer/RebalancePullImpl.java 19.23% <0.00%> (-4.58%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 50.00% <0.00%> (-2.41%) ⬇️
...in/java/org/apache/rocketmq/common/KeyBuilder.java 0.00% <0.00%> (ø)
...va/org/apache/rocketmq/common/PopAckConstants.java 0.00% <0.00%> (ø)
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df1d93f...48fa70b. Read the comment docs.

@duhenglucky duhenglucky merged commit efe598d into 5.0.0-preview Jun 29, 2021
@duhenglucky duhenglucky deleted the pop_consumer branch March 23, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/admin module/broker module/client progress/wip Work in progress. Accept or refused to be continue. type/rip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants