-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RIP-19] Server-side rebalance, lightweight consumer client support #2867
Conversation
[RIP-19] Pop Consuming (submodule "common")
[RIP-19] Pop Consuming (submodule "store")
Fix issue that when messages pop out but not ack so redeliver to retry topic, and next pop start from max offset so skip these messages incorrectly.
[RIP-19] Pop Consuming (submodule "broker")
[RIP-19] Pop Consuming (client)
[RIP-19] Pop Consuming (tools)
[RIP-19] Pop Consuming (integration test)
[RIP-19]Pop consumer docs
# Conflicts: # client/src/test/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumerTest.java # client/src/test/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumerTest.java # client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQConsumerWithTraceTest.java # pom.xml
resolve conflict, and we could review after merge it, release it in 4.9.0 after 4.8.1 |
Polish pop consume comment
Codecov Report
@@ Coverage Diff @@
## 5.0.0-preview #2867 +/- ##
===================================================
- Coverage 47.97% 46.49% -1.49%
- Complexity 4570 4789 +219
===================================================
Files 552 591 +39
Lines 36628 40253 +3625
Branches 4844 5454 +610
===================================================
+ Hits 17573 18716 +1143
- Misses 16832 19071 +2239
- Partials 2223 2466 +243
Continue to review full report at Codecov.
|
[RIP 19] Server side rebalance, lightweight consumer client support
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.