Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images should have alternate text (alt text) #1391

Closed
jbampton opened this issue Apr 30, 2024 · 0 comments · Fixed by #1627
Closed

Images should have alternate text (alt text) #1391

jbampton opened this issue Apr 30, 2024 · 0 comments · Fixed by #1627

Comments

@jbampton
Copy link
Member

Expected behavior

Images should have alt text where possible.

"Rationale: Alternate text is important for accessibility and describes the content of an image for people who may not be able to see it."

https://github.com/DavidAnson/markdownlint/blob/main/doc/md045.md

Actual behavior

We have missing alt text on some images.

Steps to reproduce the problem

Comment out or remove markdownlint rule MD045 in .github/linters/.markdown-lint.yml.

Run: git add .

This really enables checking for MD045.

Run:

sedona$ pre-commit run markdownlint --all-files | grep .md
docs/setup/overview.md:5:527 MD045/no-alt-text Images should have alternate text (alt text)
docs/setup/overview.md:5:650 MD045/no-alt-text Images should have alternate text (alt text)
docs/community/develop.md:13:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/community/develop.md:17:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/community/develop.md:23:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/community/develop.md:42:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/community/develop.md:46:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/community/develop.md:63:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/community/develop.md:67:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/community/develop.md:71:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/community/develop.md:75:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/community/develop.md:79:1 MD045/no-alt-text Images should have alternate text (alt text)
python/README.md:3:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/tutorial/sql.md:606:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/tutorial/sql.md:621:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/tutorial/sql.md:636:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/tutorial/sql.md:650:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/tutorial/sql.md:674:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/tutorial/viz-gallery.md:1:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/tutorial/viz-gallery.md:3:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/tutorial/viz-gallery.md:5:1 MD045/no-alt-text Images should have alternate text (alt text)
R/README.md:1:17 MD045/no-alt-text Images should have alternate text (alt text)
README.md:7:527 MD045/no-alt-text Images should have alternate text (alt text)
README.md:7:650 MD045/no-alt-text Images should have alternate text (alt text)
README.md:25:37 MD045/no-alt-text Images should have alternate text (alt text)
README.md:39:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/community/contact.md:22:2 MD045/no-alt-text Images should have alternate text (alt text)
docs/tutorial/zeppelin.md:31:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/tutorial/zeppelin.md:60:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/api/snowflake/vector-data/Function.md:2062:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/api/snowflake/vector-data/Function.md:2076:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/setup/fabric.md:7:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/setup/fabric.md:13:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/setup/fabric.md:19:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/setup/fabric.md:25:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/setup/fabric.md:31:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/setup/fabric.md:51:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/setup/fabric.md:53:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/setup/fabric.md:59:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/setup/fabric.md:88:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/api/sql/Optimizer.md:345:3 MD045/no-alt-text Images should have alternate text (alt text)
docs/api/sql/Optimizer.md:345:60 MD045/no-alt-text Images should have alternate text (alt text)
docs/setup/snowflake/install.md:23:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/setup/snowflake/install.md:27:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/setup/snowflake/install.md:42:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/setup/snowflake/install.md:52:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/setup/snowflake/install.md:56:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/setup/snowflake/install.md:78:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/setup/snowflake/install.md:82:1 MD045/no-alt-text Images should have alternate text (alt text)
docs/setup/snowflake/install.md:100:1 MD045/no-alt-text Images should have alternate text (alt text)

Settings

Sedona version = master

Apache Spark version = ?

Apache Flink version = ?

API type = Scala, Java, Python?

Scala version = 2.11, 2.12, 2.13?

JRE version = 1.8, 1.11?

Python version = ?

Environment = Standalone, AWS EC2, EMR, Azure, Databricks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant