Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump io.zipkin.zipkin2:zipkin from 2.26.0 to 3.1.1 #4283

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 1, 2024

Bumps io.zipkin.zipkin2:zipkin from 2.26.0 to 3.1.1.

Release notes

Sourced from io.zipkin.zipkin2:zipkin's releases.

Zipkin 3.1.1 is a hardening release, notably polishing out some UI glitches and experience problems for Cassandra users. Thanks a lot for all the feedback and patience, as we delayed this patch until we felt confident glitches were handled in a way that would be easy to diagnose in the future!

UI Fixes

Users and maintainers have noticed a few glitches since our UI moved from the abandoned react-scripts to vite for packaging. We think we've corrected everything at this point, but please reach out if you believe we didn't.

  • Fixed our test image ghcr.io/openzipkin/zipkin-ui resulting in 404s
  • Fixed handling of the env variable ZIPKIN_UI_BASEDIR, used when zipkin is deployed in a proxying

Cassandra and SASI default change

When STORAGE_TYPE=cassandra3, zipkin uses a feature called SASI for search features. This was enabled by default in Cassandra 3.11+, but in 4.x it became disabled by default.

Unlike schema settings, sasi_indexes_enabled: true is not something zipkin can change. Before, we weren't logging this critical setup problem, so users upgrading from cassandra 3 to 4 had a very hard time figuring it out. We now properly log what's going on, with more context. Ideally, this will help folks correct their configuration.

Here's an example, if you use the default cassandra docker image which has SASI disabled

2024-03-07T08:02:47.184+08:00 ERROR [/] 83635 --- [cking-tasks-2-1] z.s.c.Schema                             : Failed to execute [CREATE CUSTOM INDEX IF NOT EXISTS ON zipkin2.span (l_service) USING 'org.apache.cassandra.index.sasi.SASIIndex'
   WITH OPTIONS = {'mode': 'PREFIX'}]: SASI indexes are disabled. Enable in cassandra.yaml to use.

Build updates

While these changes won't impact end users, they do affect forks and are important.

  • we moved from long form license headers to SPDX ID
  • @​anuraaga fixed our ServerIntegratedBenchmark

Full Changelog: https://github.com/openzipkin/zipkin/compare/3.1.0..3.1.1

Zipkin 3.1 includes our first additional features since the 3.0 platform update. Notably gRPC span collection is enabled by default, Eureka registration includes more properties, and you can now disable the UI independent of the REST API. Those using kubernetes should have a second look at our helm chart which is recently renovated as well!

While most won't see this, we'd like to give a special shout out to @​SamTV12345 for helping renovate our javascript build. It was Sam's first change in the project and quite a big one. We'd like to thank all the users for your feedback and the continued support from our all volunteer team, notably @​reta and @​anuraaga who've stuck here with you so long.

Here are the changes end users might notice

  • COLLECTOR_GRPC_ENABLED is now true by default, accepting spans from the zipkin.proto3.SpanService/Report service hosted on the same HTTP port as the normal API (default 9411)
  • Eureka registration now populates the homePageUrl and statusPageUrl fields, the latter used in the spring-cloud-netflix UI. This was thanks to upstream changes in Armeria driven by @​minwoox
  • New UI_ENABLED for users who wish to expose the query API, but not host the javascript UI.

Here are the build related changes:

  • UI build now uses vite. @​SamTV12345 was the MVP of this change, which eliminated a build-time CVE. This was a quite a lot of work, and we're grateful for Sam's help. We also appreciate others work on this, too, notably @​anuraaga who advised and pitched in a test migration PR.
  • @​reta switched us to SLF4J 2.0, with heaps of thanks to @​wilkinsona who helped us come to the same page on what versions do what.
  • our zipkin-slim image now includes netty tcnative libraries.

Thank folks who helped with changes you want and don't forget to star the project if you're happy with our continued efforts! If you'd like to get in touch, please chat on gitter. See you next release!

Full Changelog: https://github.com/openzipkin/zipkin/compare/3.0.6..3.1.0

... (truncated)

Commits
  • fefb458 [maven-release-plugin] prepare release 3.1.1
  • b6f5f7f cassandra: fail at startup if search enabled, but SASI disabled (#3741)
  • e535720 docker: fixes CVE in eureka image (#3752)
  • 2bbc4bb lens: adds zipkin-uiproxy image and fixes ZIPKIN_UI_BASEPATH (#3751)
  • e16d38e fixes build status badge in README which should only report on master (#3750)
  • dad4182 license: removes copyright year and uses SPDX ID (#3749)
  • 53a735d Fix ServerIntegratedBenchmark (#3748)
  • 922f5c7 deps: bumps java deps to latest, notably Kafka (#3747)
  • 7352fb1 ui: ensures resources loaded by relative URL when baseUrl property set (#3746)
  • 85145c2 Fixed base path variable (#3745)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [io.zipkin.zipkin2:zipkin](https://github.com/openzipkin/zipkin) from 2.26.0 to 3.1.1.
- [Release notes](https://github.com/openzipkin/zipkin/releases)
- [Changelog](https://github.com/openzipkin/zipkin/blob/master/RELEASE.md)
- [Commits](openzipkin/zipkin@2.26.0...3.1.1)

---
updated-dependencies:
- dependency-name: io.zipkin.zipkin2:zipkin
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Apr 1, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.87%. Comparing base (3b07b6e) to head (60eae30).

❗ Current head 60eae30 differs from pull request most recent head a298dee. Consider uploading reports for the commit a298dee to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4283   +/-   ##
=========================================
  Coverage     44.87%   44.87%           
  Complexity     5459     5459           
=========================================
  Files          1386     1386           
  Lines         34527    34527           
  Branches       3338     3338           
=========================================
  Hits          15493    15493           
  Misses        17782    17782           
  Partials       1252     1252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liubao68 liubao68 merged commit f3e0331 into master Apr 3, 2024
4 checks passed
@dependabot dependabot bot deleted the dependabot/maven/io.zipkin.zipkin2-zipkin-3.1.1 branch April 3, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants