Update the Github Workflow for uploading conda packages #795
Conversation
The anaconda upload token is a secret on github (nudles). If the secret is not available, no uploading. Note: github ci cannot access the secret directly within the `if` check; you have to assign it to a env var first and then do if check; better do the upload on push (not on pull request).
Add the CI to run on MacOS, including building, testing pysinga and uploading the package to anaconda if the token is available. Fix the permission issue conda/conda#7267 and the sdk issue. The sdk is fixed to the latest version (in conda_build_config.yaml). The python is fixed to 3.6 to be compatible with colab.
Codecov Report
@@ Coverage Diff @@
## dev #795 +/- ##
==========================================
- Coverage 70.06% 70.05% -0.02%
==========================================
Files 100 100
Lines 11568 11573 +5
==========================================
+ Hits 8105 8107 +2
- Misses 3463 3466 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
I think it will be better to create a new separate workflow for publishing conda packages. In the conda package workflow, the build should not use ENABLE_TEST unless it is building a dev package for developers not a normal package for users. This will make the built code faster because it can use compiler optimizations which are not available in test mode and smaller because it does not contain the debug information. The packaging workflow (for conda, pypi, debian, docker, etc) should not contain the code coverage steps because (1) the code is usually not built with test enabled. (2) there is no need to upload a new coverage report for the same python test cases unless there are special test cases for the the package process itself. The packaging workflow may not run with each pull request or merge on the dev branch, but they can run periodically every week for example or only when merging with the master branch. |
Currently,
I am fine to disable code coverage for 2 and 3, i.e., conda.yaml. |
Why we cannot set the secret key? Can we ask INFRA to add the key as discussed in #790? |
The anaconda upload token is stored as a secret on github.