-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Travis CI #790
Remove Travis CI #790
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #790 +/- ##
==========================================
+ Coverage 65.08% 65.21% +0.13%
==========================================
Files 86 104 +18
Lines 4786 12414 +7628
==========================================
+ Hits 3115 8096 +4981
- Misses 1671 4318 +2647
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I have a question: the current CI use the current PR branch for CI test. In this case, if one PR fixes a bug that cause a failed CI test, some other PR still cannot pass the test unless rebased to dev branch Would it be a better practice if we use the merged code instead of the PR branch for CI test? |
It is possible to remove
or we can keep it as a guide for the PR reviewer but not requiring all PR to pass all the tests. It will be up to the PR reviewer to decide if the failed tests should be fixed in this PR or not. I would propose to keep it because sometimes it is better to discover the failed tests in the PR before the merge. But all the team can vote on the best options for triggering the workflow. There are many events for workflow trigger and may be some of them can be enabled on some specific workflows.
If the |
I think I got the difference between "push" and "pull_request" clearer now: From this webpage: https://frontside.com/blog/2020-05-26-github-actions-pull_request/ So the trigger of |
How can we set the secrets? There is no
|
There are two solutions:
|
This PR removes Travis CI since we are using Github Actions now.
tool/linting/py.sh
tool/linting/cpp.sh
Instead we can just use the output of Github's lgtm. Is this fine with everyone?
We do not have a github workflow that publishes the conda packages. If this is required, we can add the Conda Package Publish Action at the end of the conda workflow. Assuming there is secrets.ANACONDA_PASSWORD and secrets.ANACONDA_USERNAME defined in the github secrets of the user who runs this workflow.
Currently the github workflows use the latest Ubuntu only. If it is required to support another older versions, we can add them to the workflow. Travis CI was checking Ubuntu 14.04, 16.04 and 18.04.