Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SkyWalking's native ElasticSearch protocol client for ElasticSearch 6/7/8 and OpenSearch 1.x #7471

Closed
wu-sheng opened this issue Aug 17, 2021 · 0 comments · Fixed by #7634
Assignees
Labels
backend OAP backend related. core feature Core and important feature. Sometimes, break backwards compatibility.
Milestone

Comments

@wu-sheng
Copy link
Member

With the SSPL impact, we can't upgrade the HLRC anymore, unless Elastic eventually release APLv2 licensed client. But, even we have that, with current Elastic current move, the client is not usable for OpenSearch.
We(SkyWalking) don't choose side according to ASF vendor neutral guidance, but we have to follow License and laws. So, once SSPL client is there, we can't distribute with it.
Here is what I propose

  1. We remove the ElasticSearch 6.x HLRC permanently, so, we don't need to release 2 binary distributions anymore.
  2. Use HTTP Client(which lib could be determined later) + JSON for ES 6/7/8, which is also should work with OpenSearch.

For this new storage option, we could name it sw-native-elasticsearch.

@wu-sheng wu-sheng added core feature Core and important feature. Sometimes, break backwards compatibility. backend OAP backend related. labels Aug 17, 2021
@wu-sheng wu-sheng added this to the 8.8.0 milestone Aug 17, 2021
@wu-sheng wu-sheng changed the title Implement SkyWalking's ElasticSearch License for ElasticSearch 6/7/8 and OpenSearch 1.x Implement SkyWalking's native ElasticSearch protocol client for ElasticSearch 6/7/8 and OpenSearch 1.x Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. core feature Core and important feature. Sometimes, break backwards compatibility.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants