SOLR-15342 Solrj-Zookeeper: opt-out on 9x #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meaning a user who doesn't want it has to opt-out. For backwards compatibility.
janhoy
approved these changes
Sep 15, 2022
|
BTW I spot-checked the generated POM to observe the desired runtime dependency.
I disagree. This particular PR effectively augments the existing work that already has a CHANGES.txt. It's a branch specific implementation detail. Instead, I think maybe main should not only have an upgrade note but possible a mention of this difference in CHANGES.txt in its own section. |
|
I just realized this PR is on the same JIRA number as the main task, and it does not say that users need to do anything differently, so then I agree too. It will be in 10.0 that we need to document the opt-in. |
risdenk
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 9.x, Solrj-Zookeeper should be "opt-out", thus a user needs to opt-out if they don't want it. Don't change main (opt-in).
I looked at the upgrade docs for 9.1 in
solr-upgrade-notes.adocand I thought maybe just leave it be. What it says isn't wrong -- yes you will need this JAR if you use this functionality. It's unspecified wether this happens automatically or not based on Maven POM (for those that use it which is most folks for sure). In some sense it's a detail.In main, I can add a note for the 10.x upgrade to mention this, where it's more impactful / noticeable.