SOLR-16442: simplify two lucene-upgrade.md steps #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
risdenk
reviewed
Oct 19, 2022
| # ???manually get new .sha1 files??? | ||
|
|
||
| git add lucene-*-9.4.0.jar.sha1 | ||
| gradlew updateLicenses | ||
| ``` | ||
|
|
||
| ## Code |
There was a problem hiding this comment.
Personally I use ./gradlew check -x test for any changes without tests instead of just compile. I bet it's slower, but it runs all the spotless and other checks.
Then when I'm happy it builds, I remove the -x test to run tests.
Not sure this makes it better in this case :)
risdenk
approved these changes
Oct 19, 2022
HoustonPutman
approved these changes
Oct 20, 2022
cpoerschke
changed the title
asfgit
pushed a commit
that referenced
this pull request
Oct 26, 2022
(cherry picked from commit cf7246c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16442
as per https://github.com/apache/solr/pull/1056/files#r999187407