Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-16442: simplify two lucene-upgrade.md steps #1087

Merged
merged 2 commits into from
Oct 26, 2022
Merged

SOLR-16442: simplify two lucene-upgrade.md steps #1087

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c77d91
SOLR-16442: simplify 'license update' step in lucene-upgrade.md
cpoerschke Oct 19, 2022
2fa5316
remove angora.yml update from scope
cpoerschke Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 1 addition & 14 deletions dev-docs/lucene-upgrade.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,7 @@ gradlew --write-locks
### `solr/licenses` update

```
git rm lucene-*-9.3.0.jar.sha1

# ???manually get new .sha1 files???

git add lucene-*-9.4.0.jar.sha1
gradlew updateLicenses
```

## Code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I use ./gradlew check -x test for any changes without tests instead of just compile. I bet it's slower, but it runs all the spotless and other checks.

Then when I'm happy it builds, I remove the -x test to run tests.

Not sure this makes it better in this case :)

Expand Down Expand Up @@ -78,15 +74,6 @@ gradlew precommit
gradlew test
```

## Documentation

### `solr/solr-ref-guide/antora.yml` update

```
- lucene-javadocs: 'https://lucene.apache.org/core/9_3_0'
+ lucene-javadocs: 'https://lucene.apache.org/core/9_4_0'
```

## Finish

Push the local branch to github (fork) and open a pull request.
Expand Down