SOLR-16676: Test improvements #1443
Conversation
risdenk
force-pushed
the
SOLR-16676-test-improvements
branch
from
e2348d0
to
6387cf7
Compare
|
sorry, there are a lot of cosmetic changes here. while I don't disagree with these, they are 'nice to have' rather than adding some meaningful change to understand why this might be failing. if you don't mind, could you focus on failure-fixing patches first to get the builds passing reliably, and then we can make the code clean(er) and nice(er). |
solr/core/src/test/org/apache/solr/handler/TestHttpRequestId.java
Outdated
Show resolved
Hide resolved
| @Override | ||
| public void onSuccess(NamedList<Object> t) { | ||
| assertTrue(value, value.equals(MDC.get(key))); | ||
| assertEquals(value, MDC.get(key)); |
There was a problem hiding this comment.
this is a good catch, much better to have the values included in the assertion message.
I'm with you I just put this together to try to see if there were missing assertions and general cleanup. I agree it would be better to fix the underlying issue first. |
|
combined into #1444 |
https://issues.apache.org/jira/browse/SOLR-16676