Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-16676: Http2SolrClient loss of MDC context - test fixes #1444

Merged
merged 6 commits into from Mar 9, 2023

Conversation

stillalex
Copy link
Member

@stillalex stillalex commented Mar 9, 2023

https://issues.apache.org/jira/browse/SOLR-16676

Description

I am changing the MDC copy to only happen on the final callback events, success or failure, that was the one that was important in my view. chasing the intermediary threads that are processing the request/response seems to not be a good idea and was causing the MDC to get lost on the way.

Ran beast 100 on this and the test passes.

@stillalex
Copy link
Member Author

@risdenk please feel free to push #1443 on top of this with the changes you proposed

@risdenk risdenk self-assigned this Mar 9, 2023
@risdenk
Copy link
Contributor

risdenk commented Mar 9, 2023

@stillalex change looks good. I merged main, merged #1443, and ran tidy.

@risdenk risdenk changed the title SOLR-16676 Http2SolrClient loss of MDC context - test fixes SOLR-16676: Http2SolrClient loss of MDC context - test fixes Mar 9, 2023
@risdenk risdenk merged commit 9165139 into apache:main Mar 9, 2023
@stillalex
Copy link
Member Author

thanks a lot @risdenk!

if it helps I also ran a 500 over night and it passed

solr$ ./gradlew beast -p solr/core --tests TestHttpRequestId -Ptests.dups=500
BUILD SUCCESSFUL in 10h 17m 47s
524 actionable tasks: 511 executed, 13 up-to-date

@stillalex stillalex deleted the SOLR-16676-flaky branch March 9, 2023 17:23
risdenk added a commit that referenced this pull request Mar 9, 2023
Co-authored-by: Kevin Risden <krisden@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants