SOLR-6994: Backport Integrate post tool into bin/solr and bin/solr.cmd (#1634) #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the PKIAuthPlugin decorates outgoing requests at 'queue' time instead of later when they're actually sent. This can cause scenarios where, under heavy load, queue time and sending time are far enough apart that much or all of the TTL window for the outgoing request is expired by the time its even sent. This commit switches header-decoration to occur using a different lifecycle hook offered by Jetty, 'onBegin', so that it's done as close as possible to the actual time the request is sent. This won't eliminate the possibility of errant TTL expiry - a JVM might go into a long GC right after 'onBegin' for a request but before sending it on the wire. But it should reduce errant TTL expiry substantially.
Co-authored-by: David Smiley <dsmiley@apache.org>
Prior to this commit, the PKIAuthPlugin decorates outgoing requests at 'queue' time instead of later when they're actually sent. This can cause scenarios where, under heavy load, queue time and sending time are far enough apart that much or all of the TTL window for the outgoing request is expired by the time its even sent. This commit switches header-decoration to occur using a different lifecycle hook offered by Jetty, 'onBegin', so that it's done as close as possible to the actual time the request is sent. This won't eliminate the possibility of errant TTL expiry - a JVM might go into a long GC right after 'onBegin' for a request but before sending it on the wire. But it should reduce errant TTL expiry substantially.
The S3 subclass of this test has been sporadically exceeding its timeout, likely due to underlying performance problems with S3Mock itself (see PR apache#1545). This commit increases the timeout for the particular failing action slightly, and restructures a few assertions to produce more helpful error messages.
This commit makes various cosmetic improvements to Solr's v2 (collection-level) create backup API, to bring it more into line with the more REST-ful v2 design. As of this commit, the create-backup API is now: - POST /api/collections/collName/backups/backName/versions It also migrates the API definition to JAX-RS.
…izer (apache#1547) This change allows users that use TLS to configure Jetty's SecureRequestCustomizer using System properties on startup
…)" This reverts commit 8b8f9f6.
Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com>
Also added an integration test for the hadoop-auth module.
Co-authored-by: Pierre Salagnac <psalagnac@salesforce.com> SOLR-16705
This commit splits up the various functional APIs in LoggingHandler and gives them separate JAX-RS endpoints. v2 APIs are now available for: - list logger levels (GET /api/node/logging/levels) - bulk update logger levels (PUT /api/node/logging/levels) - fetch log messages (GET /api/node/logging/messages) - tweak log-listener level (PUT /api/node/logging/messages/threshold) Co-authored-by: Calvince Otieno <sir_kolly@yahoo.com> Co-authored-by: Jason Gerlowski <gerlowskija@apache.org>
…or PRS collections (apache#1549)
- Binary generation - Docker image & official Dockerfile generation/testing - Documentation
The default is 3 seconds.
* MapWriter and IteratorWriter should not be special cases for JSON writing * DocCollection, Slice and Replica now write to Json and write to Maps identically.
The methods go to PerReplicaStatesOps
This reverts commit 381bf1f. wrong branch
This reverts commit cced496. wrong branch
--------- Co-authored-by: Willdotwhite <willdotwhiteis@gmail.com>
Mention solr.useExitableDirectoryReader
…CoordinatorHttpSolrCall init (apache#1800) * Synchronize to avoid race condition in CoordinatorHttpSolrCall * ./gradlew tidy
No v2 equivalent existed prior to this commit. The new v2 API is `POST /api/cores/cName/backups`. --------- Co-authored-by: Jason Gerlowski <gerlowskija@apache.org>
bin/solr create_core and bin/solr create_collection are deprecated in favour of just using bin/solr create. This aligns the create command with how the bin/solr delete command works. Also some tech debt resolved.
…#1634) We now support the Post tool on windows by reusing the SolrCLI infrastructure, instead of having a separate post.cmd. This commit does NOT remove the post.jar compilation, or the bin/post shell script. It does update the Ref Guide to refer to bin/solr post. In the future we will want to come to a resolution on the post.jar, and maybe rename bin/solr post to something else like bin/solr indexer? We have very basic bats and unit test now.
|
Umm, this doesn't look right... |
|
I ended up instead cherry-picking into branch_9x directly... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to backport the bin/solr post command to branch_9x.