SOLR-17053: Address ClassCastException issue #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tflobbe
reviewed
Dec 6, 2023
| @@ -598,7 +598,7 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp) throw | |||
| boolean allShardsFailed = includesTopIdsPurpose && allResponsesHaveExceptions; | |||
| // if all shards fail, fail the request despite shards.tolerant | |||
| if (allShardsFailed) { | |||
| throw (SolrException) srsp.getException(); | |||
| throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, srsp.getException()); | |||
There was a problem hiding this comment.
Can the exception be anything other than a server error? Should we do something like here
There was a problem hiding this comment.
I agree completely @tflobbe ; this is what I mentioned internally :-). Perhaps create a little utility method here for this pattern used twice.
There was a problem hiding this comment.
I have addressed this in my recent commit
aparnasuresh85
force-pushed
the
solr-17053-new
branch
from
5a85f7a
to
8ebc739
Compare
tflobbe
reviewed
Dec 7, 2023
| @@ -663,6 +659,15 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp) throw | |||
| } | |||
| } | |||
|
|
|||
| public static void throwSolrException(Throwable shardResponseException) throws SolrException { | |||
There was a problem hiding this comment.
Missed on reviewing the change myself. Updated to private.
tflobbe
approved these changes
Dec 7, 2023
tflobbe
pushed a commit
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17053
Description
Please provide a short description of the changes you're making with this pull request.
Address a ClassCastException issue in the event exception in shard response is not of type org.apache.solr.common.SolrException
Solution
Please provide a short description of the approach taken to implement your solution.
Wrap the exception in shard response into org.apache.solr.common.SolrException and throw the same
Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Tests checked in as part of previous PR here: #2102. Did not introduce additional testing with this PR as it is a minor change
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.