Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-17053: Address ClassCastException issue #2123

Merged
merged 4 commits into from
Dec 7, 2023
Merged

SOLR-17053: Address ClassCastException issue #2123

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4bde528
Address ClassCastException issue
aparnasuresh85 Dec 6, 2023
8ebc739
refactor extract-method to throw solrexception
aparnasuresh85 Dec 7, 2023
66c448f
Empty-Commit to trigger a build
aparnasuresh85 Dec 7, 2023
511debc
change visibility of throwSolrException to private
aparnasuresh85 Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,7 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp) throw
boolean allShardsFailed = includesTopIdsPurpose && allResponsesHaveExceptions;
// if all shards fail, fail the request despite shards.tolerant
if (allShardsFailed) {
throw (SolrException) srsp.getException();
throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, srsp.getException());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the exception be anything other than a server error? Should we do something like here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree completely @tflobbe ; this is what I mentioned internally :-). Perhaps create a little utility method here for this pattern used twice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have addressed this in my recent commit

} else {
rsp.getResponseHeader()
.asShallowMap()
Expand Down
Loading