Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17066: Switch ConcurrentSolrClients away from core URLs #2254

Merged

Commits on Feb 2, 2024

  1. SOLR-17066: Switch ConcurrentUpdateSolrClient away from core URLs

    SOLR-17066 introduced a withDefaultCollection builder method that can be
    used in lieu of providing a core URL as a "base". (Core URLs are not
    ideal as they prevent clients from making core-agnostic requests.)
    However, Solr's own client usage still needs modified to use this new
    builder method.
    
    This commit migrates all ConcurrentUpdateSolrClient usage away from core
    URLs and towards using `withDefaultCollection` instead.
    gerlowskija committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    170f371 View commit details
    Browse the repository at this point in the history
  2. SOLR-17066: Switch LBHttpSolrClient away from core URLs

    SOLR-17066 introduced a withDefaultCollection builder method that can be
    used in lieu of providing a core URL as a "base". (Core URLs are not
    ideal as they prevent clients from making core-agnostic requests.)
    However, Solr's own client usage still needs modified to use this new
    builder method.
    
    This commit migrates all LBHttpSolrClient usage away from core
    URLs and towards using `withDefaultCollection` instead.
    gerlowskija committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    5905b71 View commit details
    Browse the repository at this point in the history
  3. SOLR-17066: Switch ConcurrentUpdateHttp2SolrClient away from core URLs

    SOLR-17066 introduced a withDefaultCollection builder method that can be
    used in lieu of providing a core URL as a "base". (Core URLs are not
    ideal as they prevent clients from making core-agnostic requests.)
    However, Solr's own client usage still needs modified to use this new
    builder method.
    
    This commit migrates all ConcurrentUpdateHttp2SolrClient usage away from core
    URLs and towards using `withDefaultCollection` instead.
    gerlowskija committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    6b3080f View commit details
    Browse the repository at this point in the history
  4. SOLR-17066: Switch LBHttp2SolrClient away from core URLs

    SOLR-17066 introduced a withDefaultCollection builder method that can be
    used in lieu of providing a core URL as a "base". (Core URLs are not
    ideal as they prevent clients from making core-agnostic requests.)
    However, Solr's own client usage still needs modified to use this new
    builder method.
    
    This commit migrates all LBHttp2SolrClient usage away from core
    URLs and towards using `withDefaultCollection` instead.
    
    Has a test failure in TestLBHttp2SolrClient that still needs resolved.
    gerlowskija committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    06a2065 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Configuration menu
    Copy the full SHA
    4059125 View commit details
    Browse the repository at this point in the history
  2. Fix compilation error

    gerlowskija committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    410676b View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Fix LBHttp2SolrClient zombie testing

    Zombie-resurrection was broken in LBHttp2SolrClient because the default
    collection wasn't being taken into account on these requests.  The root
    of the problem is the way that LBHttp2 takes in an already-constructed
    SolrClient, making it difficult to set the default collection.  (In
    contrast, LBHttpSolrClient creates a different client for each base URL
    using a common Builder - this allows it to property set the default
    collection.)
    
    This commit fixes this by created a 'DelegatingSolrClient' that LBHttp2
    can use internally around its single Http2SolrClient.  The default
    collection is set on this 'Delegating' wrapper, so that it gets picked
    up by the zombie-resurrection logic.
    gerlowskija committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    e70b2e2 View commit details
    Browse the repository at this point in the history
  2. Make check happy

    gerlowskija committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    ceb81c9 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Revert "Make check happy"

    This reverts commit ceb81c9.
    gerlowskija committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    3b9f1fd View commit details
    Browse the repository at this point in the history
  2. Revert "Fix LBHttp2SolrClient zombie testing"

    This reverts commit e70b2e2.
    gerlowskija committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    8a14233 View commit details
    Browse the repository at this point in the history
  3. Revert "Fix compilation error"

    This reverts commit 410676b.
    gerlowskija committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    36d0c47 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0af8021 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    47f7c65 View commit details
    Browse the repository at this point in the history
  6. Fix check, pt 1

    gerlowskija committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    2fd9154 View commit details
    Browse the repository at this point in the history
  7. Cleanup

    gerlowskija committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    2b91139 View commit details
    Browse the repository at this point in the history
  8. Cleanup, 2

    gerlowskija committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    0576dbf View commit details
    Browse the repository at this point in the history