-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-17066: Switch ConcurrentSolrClients away from core URLs #2254
Merged
gerlowskija
merged 16 commits into
apache:main
from
gerlowskija:SOLR-17066-cusc-remove-core-urls-pt-1
Feb 14, 2024
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
170f371
SOLR-17066: Switch ConcurrentUpdateSolrClient away from core URLs
gerlowskija 5905b71
SOLR-17066: Switch LBHttpSolrClient away from core URLs
gerlowskija 6b3080f
SOLR-17066: Switch ConcurrentUpdateHttp2SolrClient away from core URLs
gerlowskija 06a2065
SOLR-17066: Switch LBHttp2SolrClient away from core URLs
gerlowskija 4059125
Merge branch 'main' into SOLR-17066-cusc-remove-core-urls-pt-1
gerlowskija 410676b
Fix compilation error
gerlowskija e70b2e2
Fix LBHttp2SolrClient zombie testing
gerlowskija ceb81c9
Make check happy
gerlowskija 3b9f1fd
Revert "Make check happy"
gerlowskija 8a14233
Revert "Fix LBHttp2SolrClient zombie testing"
gerlowskija 36d0c47
Revert "Fix compilation error"
gerlowskija 0af8021
Revert "SOLR-17066: Switch LBHttp2SolrClient away from core URLs"
gerlowskija 47f7c65
Revert "SOLR-17066: Switch LBHttpSolrClient away from core URLs"
gerlowskija 2fd9154
Fix check, pt 1
gerlowskija 2b91139
Cleanup
gerlowskija 0576dbf
Cleanup, 2
gerlowskija File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,6 +31,8 @@ | |
/** Unit tests for {@link Builder}. */ | ||
public class ConcurrentUpdateSolrClientBuilderTest extends SolrTestCase { | ||
|
||
private static final String ANY_BASE_URL = "http://localhost:8983/solr"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nicer! |
||
|
||
@Test(expected = IllegalArgumentException.class) | ||
public void testRejectsMissingBaseSolrUrl() { | ||
new Builder(null).build(); | ||
|
@@ -39,7 +41,7 @@ public void testRejectsMissingBaseSolrUrl() { | |
@Test | ||
@SuppressWarnings({"try"}) | ||
public void testMissingQueueSize() { | ||
try (ConcurrentUpdateSolrClient client = new Builder("someurl").build()) { | ||
try (ConcurrentUpdateSolrClient client = new Builder(ANY_BASE_URL).build()) { | ||
// Do nothing as we just need to test that the only mandatory parameter for building the | ||
// client is the baseSolrUrl | ||
} | ||
|
@@ -76,7 +78,7 @@ public void testSocketTimeoutOnCommit() throws IOException, SolrServerException | |
@Test | ||
public void testDefaultCollectionPassedFromBuilderToClient() throws IOException { | ||
try (SolrClient createdClient = | ||
new ConcurrentUpdateSolrClient.Builder("someurl") | ||
new ConcurrentUpdateSolrClient.Builder(ANY_BASE_URL) | ||
.withDefaultCollection("aCollection") | ||
.build()) { | ||
assertEquals("aCollection", createdClient.getDefaultCollection()); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sigh... if only a builder new what a url was and we didn't .tostring everywhere. ;-) #beatdeadhorse