SOLR-15990: Use google-cloud-bom for gcs-repository dependencies #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risdenk
force-pushed
the
SOLR-15990
branch
3 times, most recently
from
861f86e
to
3a540e2
Compare
risdenk
changed the title
risdenk
requested review from
gerlowskija,
HoustonPutman,
janhoy,
dsmiley and
madrob
|
@gerlowskija since I pinged you on Slack about this - this PR is ready for review now that SOLR-15992 was merged. For anyone else tagged in reviews:
|
gerlowskija
approved these changes
Feb 12, 2022
There was a problem hiding this comment.
The change lgtm; thanks for taking this up Kevin.
I ran a few backups and restores and didn't run into any classpath issues, so that gives me some confidence too that the few version changes this does contain should be pretty safe.
(Unrelated, I hadn't used the GCS contrib, err...module since it was relocated/renamed on main. Very cool!)
|
Thanks @gerlowskija I'll merge this after PR #553 due to the guava upgrade. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-15990