SOLR-16244: Update typos and grammar #900

epugh · 2022-06-09T21:30:00Z

https://issues.apache.org/jira/browse/SOLR-16244

Description

I am going through the test files one by one, fixing them for typos and grammar, primarily guided by IntelliJ's "Problems" report.

Solution

Fixing batches of files, and then rerunning the tests.

Tests

Running the tests.

Checklist

Please review the following and check all that apply:

[ X] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[ X] I have created a Jira issue and added the issue ID to my pull request title.
[ X] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[X ] I have developed this patch against the main branch.
I have run ./gradlew check.
I have added tests for my changes.
I have added documentation for the Reference Guide

cpoerschke

80 / 318 files viewed

solr/core/src/test/org/apache/solr/cloud/DeleteNodeTest.java

solr/core/src/test/org/apache/solr/cloud/DistribDocExpirationUpdateProcessorTest.java

solr/core/src/test/org/apache/solr/cloud/FullSolrCloudDistribCmdsTest.java

solr/core/src/test/org/apache/solr/cloud/OverseerStatusTest.java

solr/core/src/test/org/apache/solr/cloud/OverseerTest.java

solr/core/src/test/org/apache/solr/cloud/TestSkipOverseerOperations.java

solr/core/src/test/org/apache/solr/cloud/TestStressInPlaceUpdates.java

solr/core/src/test/org/apache/solr/cloud/TestTolerantUpdateProcessorCloud.java

erikhatcher

Other than collocate/colocate change, everything else looks good. Thanks for the cleanup effort, Eric!

solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java

solr/core/src/test/org/apache/solr/cluster/placement/impl/PlacementPluginIntegrationTest.java

Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

…pdateProcessorTest.java Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

…mdsTest.java Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

…java Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

…ent.java Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

…oudTest.java Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

cpoerschke

330 / 330 files viewed

solr/core/src/test/org/apache/solr/handler/designer/TestSchemaDesignerAPI.java

solr/core/src/test/org/apache/solr/handler/designer/TestSchemaDesignerConfigSetHelper.java

solr/core/src/test/org/apache/solr/handler/designer/TestSchemaDesignerSettingsDAO.java

solr/core/src/test/org/apache/solr/search/SpatialFilterTest.java

solr/core/src/test/org/apache/solr/search/TestSolr4Spatial.java

solr/core/src/test/org/apache/solr/update/processor/DistributedUpdateProcessorTest.java

solr/core/src/test/org/apache/solr/util/hll/HLLSerializationTest.java

solr/core/src/test/org/apache/solr/cloud/TestTolerantUpdateProcessorRandomCloud.java

solr/core/src/test/org/apache/solr/cloud/TestCloudDeleteByQuery.java

solr/core/src/test/org/apache/solr/cloud/TestTolerantUpdateProcessorCloud.java

Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

solr/core/src/test/org/apache/solr/handler/designer/TestSchemaDesignerConfigSetHelper.java

epugh · 2022-06-14T20:12:48Z

Thanks @cpoerschke for all the collaboration ! I've finally reached Colorado with my family, and am about to sign off from technology for the next 10 days.

I am a bit nervous to click the "Squash and merge" button and then not be around, however if you are willing to do it, I'd much appreciate it! Then when I get back in the car to head back to Virginia, maybe we can tackle the rest of the unit tests??!!!! ;-).

solr/core/src/test/org/apache/solr/handler/designer/ManagedSchemaDiffTest.java

solr/core/src/test/org/apache/solr/handler/designer/TestSchemaDesignerAPI.java

cpoerschke

Also ran test suite locally and it passed.

epugh · 2022-06-17T23:13:19Z

Great stuff Christine!

…

On Fri, Jun 17, 2022 at 12:45 PM Christine Poerschke < ***@***.***> wrote: ***@***.**** approved this pull request. Also ran test suite locally and it passed. — Reply to this email directly, view it on GitHub <#900 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFO63VTWIBKTX6AW27BZLVPTBTLANCNFSM5YLONOZA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Review of comments, variable names, and method names for typos and grammer errors. Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

epugh added 7 commits June 8, 2022 11:35

typo and grammer fixes

a5843c0

typo and grammer

edd483e

cloud package

c832815

back out change

1cb9bc6

couple more

91008c5

revert to c23ecd6

dbd7d6c

spotless

bdb7936

epugh changed the title ~~SOLR-16244: Update typos and grammer~~ SOLR-16244: Update typos and grammar Jun 10, 2022

epugh added 9 commits June 10, 2022 08:04

core/snapshots review

aa5c10a

handler/components updated for typos and grammar

9a09fb1

remove unused test set up steps

86fe0a2

solr/handler/* typo and grammar review

677d781

typo and grammar review

e8e668e

typo and grammar review

6b7b08b

typo and grammar review

cf809eb

fat finger

5310ef0

typo and grammar review

e60d000

epugh requested a review from janhoy June 12, 2022 20:59

cpoerschke reviewed Jun 13, 2022

View reviewed changes

erikhatcher reviewed Jun 13, 2022

View reviewed changes

epugh and others added 10 commits June 13, 2022 09:45

typos and grammar review

34df29d

Update solr/core/src/test/org/apache/solr/cloud/DeleteNodeTest.java

83addbd

Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

Update solr/core/src/test/org/apache/solr/cloud/DistribDocExpirationU…

aed4bf6

…pdateProcessorTest.java Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

Update solr/core/src/test/org/apache/solr/cloud/FullSolrCloudDistribC…

0c73d6f

…mdsTest.java Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

Update solr/core/src/test/org/apache/solr/cloud/OverseerStatusTest.java

a04ea95

Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

Update solr/core/src/test/org/apache/solr/cloud/OverseerTest.java

1316940

Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

Apply suggestions from code review

925b6bb

Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

incorporate feedback

1656684

renames

f807772

spotless

7b3ee0e

epugh and others added 6 commits June 13, 2022 12:53

Update solr/core/src/test/org/apache/solr/search/RankQueryTestPlugin.…

a47488c

…java Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

Update solr/core/src/test/org/apache/solr/search/QueryEqualityTest.java

564974e

Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

Update solr/core/src/test/org/apache/solr/search/DelayingSearchCompon…

e9c6dc6

…ent.java Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

Update solr/core/src/test/org/apache/solr/search/CurrencyRangeFacetCl…

657fd4b

…oudTest.java Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

restore original test functionality

3e5bba4

spotless

0e6b280

cpoerschke reviewed Jun 14, 2022

View reviewed changes

epugh and others added 6 commits June 14, 2022 12:08

Apply suggestions from code review

efc768a

Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

Feedback from review

18dbeb4

Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

Feedback from review

6c646e5

Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

Feedback from review

25a27c6

Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

Feedback from review

a3600f4

Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

backing out changes

6d3afd9

cpoerschke reviewed Jun 14, 2022

View reviewed changes

solr/core/src/test/org/apache/solr/handler/designer/TestSchemaDesignerConfigSetHelper.java Outdated Show resolved Hide resolved

Update TestSchemaDesignerConfigSetHelper.java

7a1d86b

cpoerschke added 3 commits June 17, 2022 18:32

Apply suggestions from code review

4031b54

Apply suggestions from code review

0df5aa2

Apply suggestions from code review

127e4f4

cpoerschke reviewed Jun 17, 2022

View reviewed changes

solr/core/src/test/org/apache/solr/handler/designer/ManagedSchemaDiffTest.java Outdated Show resolved Hide resolved

Apply suggestions from code review

1d3eaf1

cpoerschke reviewed Jun 17, 2022

View reviewed changes

solr/core/src/test/org/apache/solr/handler/designer/TestSchemaDesignerAPI.java Outdated Show resolved Hide resolved

solr/core/src/test/org/apache/solr/handler/designer/TestSchemaDesignerAPI.java Outdated Show resolved Hide resolved

cpoerschke added 4 commits June 17, 2022 18:53

Apply suggestions from code review

11c01c8

Update TestSchemaDesignerAPI.java

81f68c6

spotless

202563a

Merge remote-tracking branch 'origin/main' into SOLR-16244

983b6f5

cpoerschke approved these changes Jun 17, 2022

View reviewed changes

epugh merged commit 27b0067 into apache:main Jun 27, 2022

epugh added a commit that referenced this pull request Jun 27, 2022

SOLR-16244: Update typos and grammar (#900)

e68bea1

Review of comments, variable names, and method names for typos and grammer errors. Co-authored-by: Christine Poerschke <cpoerschke@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SOLR-16244: Update typos and grammar #900

SOLR-16244: Update typos and grammar #900

epugh commented Jun 9, 2022

cpoerschke left a comment

erikhatcher left a comment

cpoerschke left a comment

epugh commented Jun 14, 2022

cpoerschke left a comment

epugh commented Jun 17, 2022 via email

SOLR-16244: Update typos and grammar #900

SOLR-16244: Update typos and grammar #900

Conversation

epugh commented Jun 9, 2022

Description

Solution

Tests

Checklist

cpoerschke left a comment

Choose a reason for hiding this comment

erikhatcher left a comment

Choose a reason for hiding this comment

cpoerschke left a comment

Choose a reason for hiding this comment

epugh commented Jun 14, 2022

cpoerschke left a comment

Choose a reason for hiding this comment

epugh commented Jun 17, 2022 via email