[SPARK-13087][SQL] Fix group by function for sort based aggregation #11011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @cloud-fan |
|
I'm investigating if this is a problem in master and will open another PR if needed. |
|
Opened #11013 for master |
|
Test build #50519 has finished for PR 11011 at commit
|
|
good catch! I think it's a mistake when we write LGTM |
|
Merging to branch 1.6. |
asfgit
pushed a commit
that referenced
this pull request
Feb 2, 2016
It is not valid to call `toAttribute` on a `NamedExpression` unless we know for sure that the child produced that `NamedExpression`. The current code worked fine when the grouping expressions were simple, but when they were a derived value this blew up at execution time. Author: Michael Armbrust <michael@databricks.com> Closes #11011 from marmbrus/groupByFunction.
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not valid to call
toAttributeon aNamedExpressionunless we know for sure that the child produced thatNamedExpression. The current code worked fine when the grouping expressions were simple, but when they were a derived value this blew up at execution time.