Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-13087][SQL] Fix group by function for sort based aggregation #11013

Closed
wants to merge 1 commit into from
Closed

[SPARK-13087][SQL] Fix group by function for sort based aggregation #11013

wants to merge 1 commit into from

Conversation

marmbrus
Copy link
Contributor

@marmbrus marmbrus commented Feb 2, 2016

It is not valid to call toAttribute on a NamedExpression unless we know for sure that the child produced that NamedExpression. The current code worked fine when the grouping expressions were simple, but when they were a derived value this blew up at execution time.

@marmbrus marmbrus mentioned this pull request Feb 2, 2016
Closed
@SparkQA
Copy link

SparkQA commented Feb 2, 2016

Test build #50521 has finished for PR 11013 at commit e16fabf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor

yhuai commented Feb 2, 2016

Thanks! Merging to master.

@asfgit asfgit closed this in 22ba213 Feb 2, 2016
@marmbrus marmbrus deleted the groupByFunction-master branch March 8, 2016 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marmbrus @SparkQA @yhuai