[SPARK-19891][SS] Await Batch Lock notified on stream execution exit #17231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you just submit one commit, please? The PR commit history will be a part of the commit message after merging. That's totally not necessary for such minor fix. |
|
Test build #74287 has finished for PR 17231 at commit
|
|
Test build #74292 has finished for PR 17231 at commit
|
|
Test build #74294 has finished for PR 17231 at commit
|
|
Test build #74293 has finished for PR 17231 at commit
|
|
LGTM. Merging to master and 2.1. |
asfgit
pushed a commit
that referenced
this pull request
Mar 10, 2017
## What changes were proposed in this pull request? We need to notify the await batch lock when the stream exits early e.g., when an exception has been thrown. ## How was this patch tested? Current tests that throw exceptions at runtime will finish faster as a result of this update. zsxwing Please review http://spark.apache.org/contributing.html before opening a pull request. Author: Tyson Condie <tcondie@gmail.com> Closes #17231 from tcondie/kafka-writer. (cherry picked from commit 501b711) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We need to notify the await batch lock when the stream exits early e.g., when an exception has been thrown.
How was this patch tested?
Current tests that throw exceptions at runtime will finish faster as a result of this update.
@zsxwing
Please review http://spark.apache.org/contributing.html before opening a pull request.