[SPARK-29971][CORE][2.4] Fix buffer leaks in TransportFrameDecoder/TransportCipher
#26660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ByteBuf
inTransportCipher
in all caseshandlerRemoved(...)
so we are guaranteed that is always called.frameBuf
it is not null when the handler is removed (and so also when the channel becomes inactive)Why are the changes needed?
We need to carefully manage the ownership / lifecycle of
ByteBuf
instances so we don't leak any of these. We did not correctly do this in all cases:Fixes netty/netty#9784.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the newly added UTs.